From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.87 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794411234; b=yv+efdsnmNqyHBml7j3e4JhN4SDJw2L9X39x8RDhYBHVhmcVJFLg97XiY1rgcSs/6wgO ANcvHfqiccQNuPCXUMzJKXNTVxz2nHf3BaXNXMnIlmwci8JbKlkyY9e+cWrmJKZ5lYbAG 8A5oSH01piIwKiD8ENKBJ2JSfcLCeoTHYq3TqqcQA666qPGvnvGhwzQVgLFyBLM7L7rQy 8RsfeNTQ3SLWE4DtUc/AfPaIoo9JCCu+g+nkOtOoEDyTN6uChErTOsnEjR1o2je79uB5z 1FkR1U9sSjFFPr9uC9sLVDFHkdOELAWlSon3pJn2qhYmhT1hNxZTr19jWW3OiEBdoyw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794411234; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=BwTjyGbtFLiEfqJNojU1wBEH3l3XXwkDvqFxjFfKBuI=; b=C0o/aDWeO3M5Bkrq1PjH7zOlW3nZIA2jqb6ERHlZhqFgnVHmVw78A1sxNq+p/JOADZgU NnSufulf2aE+sfAfzkYfbCymWnu4U3HKwqKnlJS6PbcjcEkdba6RMMHTupfb2CLYAnZig AsKGyDcCmzlVukRxeWIpqX12+zNsDb8gVRjlUi1N61FJWhajOHM4T8csVUY3tormOUQaD YLWA+lxTDXN4kCU1+kgC5jWDQQdqd58+Q2NyQ5sbWhe39yrugg4HK0hx/+KUnO4NFD3yx od94CpkHNfn4jsUobyOMTpnJFoRzeFEh7/WwCz+MHE8Fs2m3IGYjrIQ4sbX23Pd8fkw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=rfwfWMDS; arc=none smtp.remote-ip=95.215.58.87 Received: from mta1.migadu.com (out-87.mta1.migadu.com [95.215.58.87]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4232606A321 for ; Wed, 11 Nov 2026 15:33:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E4232606A321 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=rfwfWMDS X-Envelope-To: bpf@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=gboru3Ec6G1jPwlPZvGIx8shx83LrPwzmsUnld/c0C0=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794411232; v=1; x=1795016032; b=rfwfWMDS0ETzicI9TdsQtx5vCj6KU4f2QcLmX1BPodx+vlUwXUhtDletliHH5GErvxgGysOJ a/S0Lw5TWyzv3OAVGEGFsIv06BbWXEQ+Nxya0BohUSl7nWcapBGxW0AygrurSKzIZfn8AtX9bk5 sjec4ssQourGBdOWobCHMRfI= X-Envelope-To: bpf@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 17a7bba5a94a6255; Wed, 11 Nov 2026 15:32:36 +0000 X-Mizu-Trace-ID: 17a7bba5a94a6255 X-Migadu-Flow: FLOW_OUT Message-ID: <9f9f10e5-d9f2-4cac-9376-a5802424de04@linux.dev> Date: Wed, 11 Nov 2026 23:32:25 +0800 X-Mailing-List: bpf@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next 4/9] bpf: Add log support for cgroup prog link_create To: bot+bpf-ci@kernel.org, bpf@vger.kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com, martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org, emil@etsalapatis.com, ihor.solodrai@linux.dev, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, kpsingh@kernel.org, matt@bobrowski.net, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, netdev@vger.kernel.org, martin.lau@kernel.org, mason@kernel.org References: <20261109140816.5196-5-leon.hwang@linux.dev> <8a2b570a4d824e7a7acb46464af3318cc99a87ac6b620dc5cb76d9966101fd1d@mail.kernel.org> Content-Language: en-US From: Leon Hwang In-Reply-To: <8a2b570a4d824e7a7acb46464af3318cc99a87ac6b620dc5cb76d9966101fd1d@mail.kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2026/11/9 22:47, bot+bpf-ci@kernel.org wrote: >> bpf: Add log support for cgroup prog link_create > > TL;DR: Nit only: the new include in bpf-cgroup.h may be > unnecessary, since a forward declaration would likely suffice and avoid > pulling it into tcp.h users. > >> diff --git a/include/linux/bpf-cgroup.h b/include/linux/bpf-cgroup.h >> --- a/include/linux/bpf-cgroup.h >> +++ b/include/linux/bpf-cgroup.h >> @@ -4,6 +4,7 @@ >> >> #include >> #include >> +#include >> #include >> #include >> #include > > this isn't a bug, but is the include needed here? > > bpf.h already forward-declares struct bpf_verifier_log, which is all the > new cgroup_bpf_link_attach() prototype and its stub need, and cgroup.c > already includes bpf_verifier.h for bpf_log(). > > Since bpf-cgroup.h is included from include/net/tcp.h, would a plain > forward declaration (as done for trace_events.h earlier in this series) > keep the verifier header out of those translation units? > Good catch. Will drop this include. Thanks, Leon