From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: KP Singh <kpsingh@kernel.org>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Florent Revest <revest@chromium.org>,
Brendan Jackman <jackmanb@chromium.org>
Subject: Re: [PATCH v2 bpf-next] selftests/bpf: Add an option for a debug shell in vmtest.sh
Date: Thu, 25 Mar 2021 21:48:41 -0700 [thread overview]
Message-ID: <CAEf4BzY=VR4MbYiG4fPwNPVB3hKw4MckRv2sftk160H6TapMaQ@mail.gmail.com> (raw)
In-Reply-To: <20210323014752.3198283-1-kpsingh@kernel.org>
On Mon, Mar 22, 2021 at 6:47 PM KP Singh <kpsingh@kernel.org> wrote:
>
> The newly introduced -s command line option starts an interactive shell.
> If a command is specified, the shell is started after the command
> finishes executing. It's useful to have a shell especially when
> debugging failing tests or developing new tests.
>
> Since the user may terminate the VM forcefully, an extra "sync" is added
> after the execution of the command to persist any logs from the command
> into the log file.
>
> Signed-off-by: KP Singh <kpsingh@kernel.org>
> ---
I run:
./vmtest.sh -s
And I get test_progs executed, not bash. What do I do wrong?...
> tools/testing/selftests/bpf/vmtest.sh | 39 +++++++++++++++++++--------
> 1 file changed, 28 insertions(+), 11 deletions(-)
>
[...]
next prev parent reply other threads:[~2021-03-26 4:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 1:47 [PATCH v2 bpf-next] selftests/bpf: Add an option for a debug shell in vmtest.sh KP Singh
2021-03-26 4:48 ` Andrii Nakryiko [this message]
2021-03-29 13:45 ` KP Singh
2021-03-31 5:17 ` Andrii Nakryiko
2021-03-31 19:33 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzY=VR4MbYiG4fPwNPVB3hKw4MckRv2sftk160H6TapMaQ@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jackmanb@chromium.org \
--cc=kpsingh@kernel.org \
--cc=revest@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).