From: Y Song <ys114321@gmail.com>
To: Magnus Karlsson <magnus.karlsson@intel.com>
Cc: "Björn Töpel" <bjorn.topel@intel.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
netdev <netdev@vger.kernel.org>,
bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v2] libbpf: fix crash in XDP socket part with new larger BPF_LOG_BUF_SIZE
Date: Wed, 10 Apr 2019 10:29:49 -0700 [thread overview]
Message-ID: <CAH3MdRXkQzN3srL1Bmkf18Tvb7Uk1M6XQFDog7eA-fPa38Cpog@mail.gmail.com> (raw)
In-Reply-To: <1554879256-30587-1-git-send-email-magnus.karlsson@intel.com>
On Tue, Apr 9, 2019 at 11:55 PM Magnus Karlsson
<magnus.karlsson@intel.com> wrote:
>
> In commit da11b417583e ("libbpf: teach libbpf about log_level bit 2"),
> the BPF_LOG_BUF_SIZE was increased to 16M. The XDP socket part of
> libbpf allocated the log_buf on the stack, but for the new 16M buffer
> size this is not going to work. Change the code so it uses a 16K buffer
> instead.
>
> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Acked-by: Yonghong Song <yhs@fb.com>
> ---
> v2: simplified code as suggested by Daniel Borkmann
>
> tools/lib/bpf/xsk.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
prev parent reply other threads:[~2019-04-10 17:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 6:54 [PATCH bpf-next v2] libbpf: fix crash in XDP socket part with new larger BPF_LOG_BUF_SIZE Magnus Karlsson
2019-04-10 7:58 ` Daniel Borkmann
2019-04-10 17:29 ` Y Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH3MdRXkQzN3srL1Bmkf18Tvb7Uk1M6XQFDog7eA-fPa38Cpog@mail.gmail.com \
--to=ys114321@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).