From: Cong Wang <xiyou.wangcong@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Cong Wang <cong.wang@bytedance.com>
Subject: Re: [Patch bpf-next v2 0/5] bpf: introduce timeout map
Date: Tue, 15 Dec 2020 12:12:28 -0800 [thread overview]
Message-ID: <CAM_iQpVn1dQJGTToiccy=g5dtYkimpf=RJrQL0iSpQjP5RwetA@mail.gmail.com> (raw)
In-Reply-To: <CAEf4Bza1tAnAMVw8g4z2UviYqWxgarOXZX2JDTShYyk-NLAo6A@mail.gmail.com>
On Tue, Dec 15, 2020 at 11:29 AM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
>
> On Mon, Dec 14, 2020 at 12:13 PM Cong Wang <xiyou.wangcong@gmail.com> wrote:
> >
> > From: Cong Wang <cong.wang@bytedance.com>
> >
> > This patchset introduces a new bpf hash map which has timeout.
>
> It's a bit too short a cover letter for a pretty major new type of
> hash maps. Please expand on the problem it's trying to solve, how you
> tested and benchmarked it, etc.
I prefer to put everything in each patch description, because `git log` is easy
to find it after merging. (I know we can retain this cover letter but
it is not directly
shown in `git log kernel/bpf/hashtab.c`)
Please reply to patch 3 if you think anything is missing in its description.
Thanks!
prev parent reply other threads:[~2020-12-15 20:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 20:11 [Patch bpf-next v2 0/5] bpf: introduce timeout map Cong Wang
2020-12-14 20:11 ` [Patch bpf-next v2 1/5] bpf: use index instead of hash for map_locked[] Cong Wang
2020-12-14 20:11 ` [Patch bpf-next v2 2/5] bpf: introduce timeout map Cong Wang
2020-12-15 19:27 ` Andrii Nakryiko
2020-12-15 20:06 ` Cong Wang
2020-12-15 22:03 ` Andrii Nakryiko
2020-12-15 23:23 ` Daniel Borkmann
2020-12-16 0:22 ` Cong Wang
2020-12-16 1:14 ` Alexei Starovoitov
2020-12-16 2:10 ` Cong Wang
2020-12-16 2:35 ` Alexei Starovoitov
2020-12-16 10:38 ` David Laight
2020-12-17 5:06 ` Cong Wang
2020-12-17 22:39 ` Daniel Borkmann
2020-12-16 0:15 ` Cong Wang
2020-12-16 18:35 ` Andrii Nakryiko
2020-12-17 6:29 ` Cong Wang
2020-12-17 21:14 ` Cong Wang
2020-12-18 19:14 ` Andrii Nakryiko
2020-12-18 19:13 ` Andrii Nakryiko
2020-12-14 20:11 ` [Patch bpf-next v2 3/5] selftests/bpf: update elem_size check in map ptr test Cong Wang
2020-12-14 20:40 ` Andrey Ignatov
2020-12-14 20:11 ` [Patch bpf-next v2 4/5] selftests/bpf: add a test case for bpf timeout map Cong Wang
2020-12-14 20:11 ` [Patch bpf-next v2 5/5] selftests/bpf: add timeout map check in map_ptr tests Cong Wang
2020-12-14 20:41 ` Andrey Ignatov
2020-12-15 19:28 ` [Patch bpf-next v2 0/5] bpf: introduce timeout map Andrii Nakryiko
2020-12-15 20:12 ` Cong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAM_iQpVn1dQJGTToiccy=g5dtYkimpf=RJrQL0iSpQjP5RwetA@mail.gmail.com' \
--to=xiyou.wangcong@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).