From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D8571F30AD for ; Sun, 24 Aug 2025 16:39:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756053587; cv=none; b=EbKrtdpqspnaz7PsCWzCQCdg/eWAcG1szu7eD6alLvSehX61wVXld2uXXcXgJijfHqDrYq3e98g4I5aLeozGfbOZlntIP8nSKw+IMVM7N5V0uauG6HM/88pHfNNv4C/gxGHTVqZ1Mg6ieA6o7RYJgaYvWeIJF3htiMKbwzz3Tho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756053587; c=relaxed/simple; bh=rzbrFRokTuoA/BGlN6chg/kU+YDV0lrR5n5SZHBY0yw=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=KHtih9hrSzCmmTFvRKY3RdrgsrgOJQ90mZLhFM16HGbCNuGlCKO3DrE7hqOVH3JD9BWoH3+YYlvx8m75opG+djdkbQPj1CZujfFkmak4xmgHaNYWzbUUVqnialL5kFqM7jEheoWg8Y594iHxd1KfaE4SjgdB7GccuUEJ6bkOmMQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Op9ejKhW; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Op9ejKhW" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-246013de800so191165ad.0 for ; Sun, 24 Aug 2025 09:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1756053586; x=1756658386; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rzbrFRokTuoA/BGlN6chg/kU+YDV0lrR5n5SZHBY0yw=; b=Op9ejKhWjCevJKaYaa50JJDt8i5ttXRG6lPWM02X0teKKUHFlgtSuVHGRGa/ipaMZE 9SgdRNNWL0wlkaK3itONtonk6n2i29qryp6yCJ27rNwNtdtHjahSc7myvB9O8QvHTXKQ H8zzNTvc8BEnCCCLZa2ow67GjdxN7XNKc4z9ouZT6WQtLjz0RjoqGXMqWk2uW/yn4b0F ALl2vTOE6oEccYuyDR1tUgbrtd5Zd561C2TvhD2IuHdEAoCNOv0e5+iDXDTdh4k+pjYm l/LclS3z8tUjl+nlICti/GjqmgHTAt4zL6Tw+9/OWZZ89Jb0yXYbHcSTlbl2aOjwJnTb 7nEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756053586; x=1756658386; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rzbrFRokTuoA/BGlN6chg/kU+YDV0lrR5n5SZHBY0yw=; b=VodY/OasQgPchhtxnhxizQUqWdkf4Kv2yF0gGyo5lthOX4+iLQQmwxh69nr+2+YfpW hgntXMtB6fHAe9TffGp1qgQXVEIjAxTvfmnWn4U4V7UHWNuzVdpdFuXcVhWfiBT8FRXI Nnd1dXbjYmYSI5/RHlWwXCtUwAHJ8ltiZfBmU2He0Iofu87hsmYa8r0LD5CrvMHfkF6T 9KKczs/c5I0T8w3sqEJx1fnuVTfWPwpOnRBGZAWHTi4x03p7BGHE/ZVz3WTfR19/iW1m k+iPsJnxmzi8F+rw9/kZtP2Jt+jWaAia3aUFY+DonFbY9QJdKpG4jOLsH9woNKTGR50Z 8E9A== X-Forwarded-Encrypted: i=1; AJvYcCXOY0UNdwRG1kZGiy1t+TvTGmtPKwWy9NE7oykext/JQpB1OSiTtjV1rCr/tBVXpTyp9Es=@vger.kernel.org X-Gm-Message-State: AOJu0YzSf5VBIrLKuwifUYijwrTF8A0KSGCji4ebAP6QwOuyu0JB8kQa W/prHO3/c9lkMOFgf95aIm6GhWXi19ng+6yfY5mooenXFZexfR0ANaqO4/3AIxnwsFDT4C4GJWt KGPJP02zDFzOGoeZxHIq4Mu6pWvnA0O5omyw/hwSy X-Gm-Gg: ASbGncs92qIM87EABezOzcUOooFBClit0YLbVElNRxn7HuLKKLWuC3m/de5RAz8k1e8 ztQCoKQOuEETVbAqNltR8CN2EjpdX2Lq89f8JXRW1lmElIdJzUOf7uIwh+04aRVSxZN+a2/CE4U ufKddWzoKNYBFTPc2B6/WSHnah4MRN8gri34ZpFC1+mqQZZx5NMsco2y2So0xFH+IQtOZSqzQeO 3NsPdwDpwM/8dk2RyvnwBg1UA== X-Google-Smtp-Source: AGHT+IF8ztkEHXB7jHNLH5b0qoR949xdKvlTltrfHLNI9mn4T2PAdsWoPgL0Nz5jySsDqNoznj8VNBGkS1VgvZI1Uk4= X-Received: by 2002:a17:902:cecc:b0:236:7079:fb10 with SMTP id d9443c01a7336-2467a21e4c1mr3101485ad.3.1756053585241; Sun, 24 Aug 2025 09:39:45 -0700 (PDT) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250823003216.733941-1-irogers@google.com> In-Reply-To: From: Ian Rogers Date: Sun, 24 Aug 2025 09:39:33 -0700 X-Gm-Features: Ac12FXzo4nNl7CWXzsGv5Kuj8o4HmwvIozQ_8cCU8zkwDdeVOkH53u0lihj7JbY Message-ID: Subject: Re: [PATCH v5 00/19] Support dynamic opening of capstone/llvm remove BUILD_NONDISTRO To: Andi Kleen Cc: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , Kan Liang , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Aditya Gupta , "Steinar H. Gunderson" , Charlie Jenkins , Changbin Du , "Masami Hiramatsu (Google)" , James Clark , Kajol Jain , Athira Rajeev , Li Huafei , Dmitry Vyukov , Chaitanya S Prakash , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, llvm@lists.linux.dev, Song Liu , bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Aug 23, 2025 at 4:34=E2=80=AFPM Andi Kleen wro= te: > > > BUILD_NONDISTRO is used to build perf against the license incompatible > > libbfd and libiberty libraries. As this has been opt-in for nearly 2 > > years, commit dd317df07207 ("perf build: Make binutil libraries opt > > in"), remove the code to simplify the code base. > > The last time I tried the LLVM stuff was totally broken, couldn't > resolve many things. The only workaround was to go back to the actually > working libbfd. Please don't remove the only working option. Andi, did you report a bug? Does the non-libbfd stuff work? Yes, as every distribution has shipped it since binutils went to GPLv3 (in 2007?). While I don't want LLVM stuff not to work, bugs happen, libbfd is license incompatible with GPLv2 and maintaining it in the source tree is a burden. When something doesn't work, create a test to repeat the issue and then we can make it work and ensure it doesn't break again. In general I've not had issues with the LLVM code. Thanks, Ian