From: Song Liu <songliubraving@meta.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Song Liu <song@kernel.org>, Ilya Leoshkevich <iii@linux.ibm.com>,
Song Liu <songliubraving@meta.com>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@kernel.org>,
Kernel Team <kernel-team@meta.com>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v2 bpf-next] bpf: Avoid unnecessary -EBUSY from htab_lock_bucket
Date: Thu, 12 Oct 2023 06:01:26 +0000 [thread overview]
Message-ID: <D1ABC3D7-BBC8-4294-BA92-EDEC29DDDF15@fb.com> (raw)
In-Reply-To: <CAEf4BzbaWL_AJ55E+nniexL04nhTegR0DWCd4bLyXW8rXVGegg@mail.gmail.com>
> On Oct 11, 2023, at 5:42 PM, Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
>
> On Tue, Oct 10, 2023 at 3:13 PM Song Liu <song@kernel.org> wrote:
>>
>> Hi Ilya,
>>
>> On Tue, Oct 10, 2023 at 1:49 PM Ilya Leoshkevich <iii@linux.ibm.com> wrote:
>>>
>> [...]
>>>>
>>>> Thanks,
>>>> Song
>>>>
>>>> PS: the root image from the CI is not easy to use. Hopefully you
>>>> have something better than that.
>>>
>>> Hi,
>>>
>>> Thanks for posting the analysis and links to the artifacts, that saved
>>> me quite some time. The crash is caused by a backchain issue in the
>>> trampoline code and has nothing to do with your patch; I've posted the
>>> fix here [1].
>>
>> Thanks for the fix!
>>
>> Song
>
> Song, can you please resend your patch so that CI can test it again on
> top of Ilya's changes? Thanks!
Sure. Just sent the patch to bpf tree.
Thanks,
Song
prev parent reply other threads:[~2023-10-12 6:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 0:43 [PATCH v2 bpf-next] bpf: Avoid unnecessary -EBUSY from htab_lock_bucket Song Liu
2023-10-04 3:08 ` Andrii Nakryiko
2023-10-04 3:33 ` Alexei Starovoitov
2023-10-04 16:18 ` Song Liu
2023-10-05 0:11 ` Song Liu
2023-10-05 1:50 ` Song Liu
2023-10-06 1:15 ` Song Liu
2023-10-09 14:58 ` Ilya Leoshkevich
2023-10-10 20:48 ` Ilya Leoshkevich
2023-10-10 22:13 ` Song Liu
2023-10-12 0:42 ` Andrii Nakryiko
2023-10-12 6:01 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1ABC3D7-BBC8-4294-BA92-EDEC29DDDF15@fb.com \
--to=songliubraving@meta.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=iii@linux.ibm.com \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
--cc=song@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox