BPF List
 help / color / mirror / Atom feed
From: "Achill Gilgenast" <fossdd@pwned.life>
To: "Eduard Zingerman" <eddyz87@gmail.com>,
	"Yonghong Song" <yonghong.song@linux.dev>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Viktor Malik" <vmalik@redhat.com>, <bpf@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
	"Martin KaFai Lau" <martin.lau@linux.dev>,
	"Song Liu" <song@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"KP Singh" <kpsingh@kernel.org>,
	"Stanislav Fomichev" <sdf@fomichev.me>,
	"Hao Luo" <haoluo@google.com>, "Jiri Olsa" <jolsa@kernel.org>,
	"Achill Gilgenast" <fossdd@pwned.life>
Subject: Re: [PATCH] libbpf: avoid possible use of uninitialized mod_len
Date: Fri, 01 Aug 2025 14:04:54 +0200	[thread overview]
Message-ID: <DBR2SLKGO5OO.276GT83Y3D6DA@pwned.life> (raw)
In-Reply-To: <20250801114613.610070-1-fossdd@pwned.life>

On Fri Aug 1, 2025 at 1:46 PM CEST, Achill Gilgenast wrote:
> If not fn_name, mod_len does never get initialized which fails now with
> gcc15 on Alpine Linux edge:
>
> 	libbpf.c: In function 'find_kernel_btf_id.constprop':
> 	libbpf.c:10100:33: error: 'mod_len' may be used uninitialized [-Werror=maybe-uninitialized]
> 	10100 |                 if (mod_name && strncmp(mod->name, mod_name, mod_len) != 0)
> 	      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 	libbpf.c:10070:21: note: 'mod_len' was declared here
> 	10070 |         int ret, i, mod_len;
> 	      |                     ^~~~~~~
>
> Signed-off-by: Achill Gilgenast <fossdd@pwned.life>
> Acked-by: Yonghong Song <yonghong.song@linux.dev>
> Acked-by: Eduard Zingerman <eddyz87@gmail.com>
> Link: https://lore.kernel.org/bpf/20250729094611.2065713-1-fossdd@pwned.life/

Oops, the subject should've been v2. I forgot to pass -v2 to git
send-email.

  reply	other threads:[~2025-08-01 12:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29  9:45 [PATCH] libbpf: avoid possible use of uninitialized mod_len Achill Gilgenast
2025-07-29 16:17 ` Yonghong Song
2025-07-30 16:13   ` Eduard Zingerman
2025-08-01 11:46     ` Achill Gilgenast
2025-08-01 12:04       ` Achill Gilgenast [this message]
2025-08-01 15:16         ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBR2SLKGO5OO.276GT83Y3D6DA@pwned.life \
    --to=fossdd@pwned.life \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=sdf@fomichev.me \
    --cc=song@kernel.org \
    --cc=vmalik@redhat.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox