From: "Emil Tsalapatis" <emil@etsalapatis.com>
To: <bot+bpf-ci@kernel.org>, <bpf@vger.kernel.org>
Cc: <andrii@kernel.org>, <ast@kernel.org>, <daniel@iogearbox.net>,
<eddyz87@gmail.com>, <etsal@meta.com>, <ihor.solodrai@linux.dev>,
<martin.lau@kernel.org>, <memxor@gmail.com>,
<puranjay@kernel.org>, <song@kernel.org>,
<yonghong.song@linux.dev>, <clm@meta.com>
Subject: Re: [PATCH v2 07/13] selftests: bpf: Add ASAN support for libarena selftests
Date: Tue, 27 Jan 2026 13:45:35 -0500 [thread overview]
Message-ID: <DFZLEW55QIGU.VTQKPNOP181D@etsalapatis.com> (raw)
In-Reply-To: <c754c6bb656d78e6ab566d3308a9a261cab980c622adab5213127e8d729efb03@mail.kernel.org>
On Tue Jan 27, 2026 at 1:38 PM EST, bot+bpf-ci wrote:
>> diff --git a/tools/testing/selftests/bpf/libarena/selftests/selftest.c b/tools/testing/selftests/bpf/libarena/selftests/selftest.c
>> index 5b8d8b94323e..f63324a1cdde 100644
>> --- a/tools/testing/selftests/bpf/libarena/selftests/selftest.c
>> +++ b/tools/testing/selftests/bpf/libarena/selftests/selftest.c
>
> [ ... ]
>
>> @@ -211,8 +269,17 @@ static void
>> banner(const char *progpath)
>> {
>> char *name = basename(progpath);
>> + bool is_asan;
>> +
>> + /*
>> + * Check if our BPF programs are ASAN-capable by inspecting the prog name.
>> + * Command line arguments are guaranteed to be NULL-terminated, use strlen.
>> + * Calculate the hardcoded name's length at compile time.
>> + */
>> + printf("%s\n", name);
>> + is_asan = strstr(name, "_asan");
>
> This isn't a bug, but the comment mentions strlen and compile-time length
> calculation, while the actual code uses strstr(). Should the comment be
> updated to match the implementation?
>
Ack, will update.
>> +
>> + printf("=== %s %s===\n", "libarena selftests", is_asan ? "(asan) " : "");
>> }
>
>
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
>
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21409286496
>
> AI-authorship-score: low
> AI-authorship-explanation: Code follows standard kernel patterns with a comment/code mismatch typical of iterative human development rather than AI generation.
> issues-found: 1
> issue-severity-score: low
> issue-severity-explanation: Minor documentation issue where comment mentions strlen and compile-time calculation but code uses strstr; does not affect functionality.
next prev parent reply other threads:[~2026-01-27 18:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 18:15 [PATCH v2 00/13] bpf: Add arena ASAN runtime and BPF library Emil Tsalapatis
2026-01-27 18:15 ` [PATCH v2 01/13] bpf: Add bpf_stream_print_stack stack dumping kfunc Emil Tsalapatis
2026-01-27 19:17 ` Mykyta Yatsenko
2026-01-27 23:23 ` Emil Tsalapatis
2026-01-27 23:53 ` Kumar Kartikeya Dwivedi
2026-01-27 18:15 ` [PATCH v2 02/13] bpf: Allow BPF stream kfuncs while holding a lock Emil Tsalapatis
2026-01-28 0:01 ` Kumar Kartikeya Dwivedi
2026-01-27 18:15 ` [PATCH v2 03/13] selftests: bpf: Move bpf_arena_spin_lock.h to the top level Emil Tsalapatis
2026-01-28 0:13 ` Kumar Kartikeya Dwivedi
2026-01-27 18:16 ` [PATCH v2 04/13] selftests: bpf: Make WRITE_ONCE macro in bpf_atomic.h conditional Emil Tsalapatis
2026-01-27 19:26 ` Mykyta Yatsenko
2026-01-27 23:41 ` Emil Tsalapatis
2026-01-27 23:56 ` Kumar Kartikeya Dwivedi
2026-01-27 18:16 ` [PATCH v2 05/13] selftests: bpf: Add basic libarena scaffolding Emil Tsalapatis
2026-01-28 0:32 ` Alexei Starovoitov
2026-01-28 0:42 ` Kumar Kartikeya Dwivedi
2026-01-27 18:16 ` [PATCH v2 06/13] selftests: bpf: Add arena ASAN runtime to libarena Emil Tsalapatis
2026-01-28 2:27 ` Alexei Starovoitov
2026-01-27 18:16 ` [PATCH v2 07/13] selftests: bpf: Add ASAN support for libarena selftests Emil Tsalapatis
2026-01-27 18:38 ` bot+bpf-ci
2026-01-27 18:45 ` Emil Tsalapatis [this message]
2026-01-27 18:16 ` [PATCH v2 08/13] selftest: bpf: Add bump allocator for libarena Emil Tsalapatis
2026-01-28 2:36 ` Alexei Starovoitov
2026-01-27 18:16 ` [PATCH v2 09/13] selftests: bpf: Add libarena selftests for the bump allocator Emil Tsalapatis
2026-01-27 18:16 ` [PATCH v2 10/13] selftest: bpf: Add libarena stack allocator Emil Tsalapatis
2026-01-27 18:49 ` bot+bpf-ci
2026-01-27 18:16 ` [PATCH v2 11/13] selftests: bpf: Add selftests for the " Emil Tsalapatis
2026-01-28 2:35 ` Alexei Starovoitov
2026-01-27 18:16 ` [PATCH v2 12/13] selftests: bpf: Add buddy allocator for libarena Emil Tsalapatis
2026-01-27 18:49 ` bot+bpf-ci
2026-01-27 18:16 ` [PATCH v2 13/13] selftests: bpf: Add selftests for the libarena buddy allocator Emil Tsalapatis
2026-01-27 18:38 ` bot+bpf-ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFZLEW55QIGU.VTQKPNOP181D@etsalapatis.com \
--to=emil@etsalapatis.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=etsal@meta.com \
--cc=ihor.solodrai@linux.dev \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
--cc=puranjay@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox