From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4FDA286425 for ; Sat, 28 Feb 2026 21:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772313968; cv=none; b=iqK63e7GY3G0I7+j6wu6HlghI/LRNVpCWZ8JaVY1hPOf1JJZwyyIKati410W4FIGgTxU0FwZviOFYSmOsNU5LIQgXKsd3fuCcWNCZyKUydJzq6ikLIvWWWosO+7YcxfP5BYHGJ69V1rauvDWnqZzJ18Vi1QwRB7dOfGbCTxKGXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772313968; c=relaxed/simple; bh=47ANglfpJaT9gxs4Ja0c8tB6Igre4d/I8jTE/gJ4xwU=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=fgea5+dXnf1e/IMpr/PS31M3G7dYhfVnoIEh7P1RvIbG23xou3UBJnHLLi18pG5T33Yr6qZathqIbI8NVZMyPMMb+mEjhMq8Z08cLkFsIX8q5/asEjPPSeL1JGQQHE/w2Vp2+21aKPFw3xwvGTahgjyx8cIrDugZeQR0E7Vdcrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com; spf=pass smtp.mailfrom=etsalapatis.com; dkim=pass (2048-bit key) header.d=etsalapatis-com.20230601.gappssmtp.com header.i=@etsalapatis-com.20230601.gappssmtp.com header.b=bxj/dmtp; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=etsalapatis.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=etsalapatis-com.20230601.gappssmtp.com header.i=@etsalapatis-com.20230601.gappssmtp.com header.b="bxj/dmtp" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-506a67282a0so33200331cf.0 for ; Sat, 28 Feb 2026 13:26:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=etsalapatis-com.20230601.gappssmtp.com; s=20230601; t=1772313965; x=1772918765; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=nihN1Pv89Y5xMabUVLFDrUWeZpS1i87V0sy0blxBCWQ=; b=bxj/dmtpLctyN001I+rson+kTAfIE8ALAwtDio5SHHwQEN//U6FueiPAHIouh7JH1r cPQqk4aQQQ1XqwYCrzaW1MQ36Wx08eIylYXxZ6Z49GpWqHpJ/t1esKeiJU8PNFxlVHku EXmSTPIAIESFNNPQgOqm6PI75sTlr1c8GSOVoVTQu4JBKla7j3/+RX+aMJbCf9DYDFCa ETKhy7b3VA/RoWtXtg4rSR1V2jecj/sbGdwHYeZO60E8OGbW9fIjQSQftamrSnCdOuF0 OnWSjmqw/42wzL7hpjizCk+KdhVLjfQLJ9y0/3DVeGWQyPzW2miNbAEfPQ+hwCpzW+Qv yaiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772313965; x=1772918765; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nihN1Pv89Y5xMabUVLFDrUWeZpS1i87V0sy0blxBCWQ=; b=UKmDxNcX4ag1NtzrpkkY0mJsHX1+Cc9WTHhv7aUp6ItHAm5DMO7djZvqguuC1ib2pB he1NiyDvhKFZRNCUYZH+hwaBlhYlJWbaFWAciLjdo9AUftCFwr+m6HzM73h5h9+l7BEP hppAxc1EsYjTV5IIt/thi1rac4eIFalD3qHYFHP8IHW2t8unB8wPs5hEHDG6TxsM6vNx L4aE4JiF4FT5SmRrvfx6AR6K7D0e9XIj2IVcIu+PbItpANJfwY50LvIJsqlpoPDYjPpX 44dbkM8ckBRVzK7+h7XIk7WZwwJ+f820Lu87PJPCa4pgO+e/e6gLfigjl/dH5zxq6c+o LCzQ== X-Forwarded-Encrypted: i=1; AJvYcCVw2MpXBDG9x8CJjq2oAVp3sX/gYaPDZljH2SWlGDQoAhQcw2YeistVrEQF4I8aH2cNtLc=@vger.kernel.org X-Gm-Message-State: AOJu0YyJZeHfRdlOBuY8ImoMtBh1iO3mNDAA9meh+Fgp8Zrlm06ySNxj ZNuMhr2HPmq5HgGUZkuByvb7jeRFv6abohAUhvIPq8+MOKb4PcPQhXrsE76uOEvape0= X-Gm-Gg: ATEYQzwxQcaal27jwpbBHOqeSoocXBECSQ5Am3jwIo+Len2XF18R3jC4m79lp9SjJPF AACK28bxvRBGgcCQdFuo0b+dTrP7/i3KxtyLjt5fXKrV3zaqwm3pq1dawq8+TnmfiujyvjpmtgV ZrrvZcyuwCb89FLyLluvi/+aW+EoNQ+7npWucLmTsiLZFFn8Im/2P7NZDEJEgvhdjioXh+5w4oO eZG0FX1eroZxmv0+imihDwXljZEkiB8dTu8bURI0L/vk2Usq6KWMrd4PYOpENQj4l7Mk5I4xTeT x00fqeuFBs378dgdgH8Eb7bJZy9Cq7SYmDlg9eymWNuBM3wsqqJ0qaUkkSoy2qeC8SF+lozniQt QFzwJyjOMBlEJGRnR4kEDjjR1/52G1TZ15Hf0XrjDpGjT93tBimcihCquyZdKGPNzVSkNspskug 2PZZhhqr03nxZ9WSWbXjHSqLR2P/55aXSyew== X-Received: by 2002:a05:622a:203:b0:4ff:8da6:2289 with SMTP id d75a77b69052e-507528d2b3bmr92975801cf.27.1772313965464; Sat, 28 Feb 2026 13:26:05 -0800 (PST) Received: from localhost ([140.174.219.137]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5074481c0e5sm84462561cf.0.2026.02.28.13.26.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Feb 2026 13:26:05 -0800 (PST) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 28 Feb 2026 16:26:03 -0500 Message-Id: Cc: "Hui Zhu" Subject: Re: [PATCH bpf-next v3 0/3] Fix test_cgroup_iter_memcg issues found during back-porting From: "Emil Tsalapatis" To: "Hui Zhu" , "Alexei Starovoitov" , "Daniel Borkmann" , "Andrii Nakryiko" , "Martin KaFai Lau" , "Eduard Zingerman" , "Song Liu" , "Yonghong Song" , "John Fastabend" , "KP Singh" , "Stanislav Fomichev" , "Hao Luo" , "Jiri Olsa" , "Shuah Khan" , "JP Kobryn" , "Roman Gushchin" , , , X-Mailer: aerc 0.20.1 References: In-Reply-To: On Sat Feb 28, 2026 at 2:11 AM EST, Hui Zhu wrote: > From: Hui Zhu > > While back-porting "mm: bpf kfuncs to access memcg data", I > encountered issues with test_cgroup_iter_memcg, specifically > in test_kmem. > > These patches are my fixes for the problems I encountered. > Nit: Could you be a bit more descriptive about the series' contents? Cover letters normally focus on what what the patch does - for example the issues being found during backporting is not pertinent to the patchset= =20 itself, because the issues are still present on bpf-next. > Changelog: > v3: > According to the comments of JP Kobryn, remove kmem subtest from > cgroup_iter_memcg and fix assertion string in test_pgfault. > v2: > According to the comments of JP Kobryn, added bpf_core_enum_value() > usage in the BPF program to handle cross-kernel enum value differences > at load-time instead of compile-time. > Dropped the mm/memcontrol.c patch. > Modified test_kmem handling: instead of skipping when nokmem is set, > verify that kmem value is zero as expected. > According to the comments of bot, fixed assertion message: changed > "bpf_mem_cgroup_page_state" to "bpf_mem_cgroup_vm_events" for PGFAULT > check. > > Hui Zhu (3): > selftests/bpf: Remove kmem subtest from cgroup_iter_memcg > bpf: Use bpf_core_enum_value for stats in cgroup_iter_memcg > selftests/bpf: Check bpf_mem_cgroup_page_state return value > > .../testing/selftests/bpf/cgroup_iter_memcg.h | 2 - > .../bpf/prog_tests/cgroup_iter_memcg.c | 38 +++++-------------- > .../selftests/bpf/progs/cgroup_iter_memcg.c | 18 ++++++--- > 3 files changed, 22 insertions(+), 36 deletions(-)