Re: [PATCH bpf-next v4 2/7] bpf: Enable unaligned accesses for syscall ctx

["Emil Tsalapatis" <emil@etsalapatis.com>]

On Wed Apr 1, 2026 at 8:28 AM EDT, Kumar Kartikeya Dwivedi wrote:
> Don't reject usage of fixed unaligned offsets for syscall ctx. Tests
> will be added in later commits. Unaligned offsets already work for
> variable offsets.
>
> Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>

Reviewed-by: Emil Tsalapatis <emil@etsalapatis.com>

> ---
>  kernel/bpf/syscall.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c
> index 51ade3cde8bb..f06fe9a9b1d3 100644
> --- a/kernel/bpf/syscall.c
> +++ b/kernel/bpf/syscall.c
> @@ -6348,8 +6348,7 @@ static bool syscall_prog_is_valid_access(int off, int size,
>  {
>  	if (off < 0 || off >= U16_MAX)
>  		return false;
> -	if (off % size != 0)
> -		return false;
> +	/* No alignment requirements for syscall ctx accesses. */
>  	return true;

Nit: Isn't this now just:

return 0 <= off && off < U16_MAX;

?

>  }
>