public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Mykyta Yatsenko" <mykyta.yatsenko5@gmail.com>,
	<bpf@vger.kernel.org>, <ast@kernel.org>, <andrii@kernel.org>,
	<daniel@iogearbox.net>, <kafai@meta.com>, <kernel-team@meta.com>,
	<eddyz87@gmail.com>, <memxor@gmail.com>, <peterz@infradead.org>,
	<rostedt@goodmis.org>
Cc: "Mykyta Yatsenko" <yatsenko@meta.com>
Subject: Re: [PATCH bpf-next v10 2/6] bpf: Add bpf_prog_run_array_sleepable()
Date: Wed, 15 Apr 2026 18:41:43 -0700	[thread overview]
Message-ID: <DHU7408DLITK.2DC76VINL2F7K@gmail.com> (raw)
In-Reply-To: <20260415-sleepable_tracepoints-v10-2-161f40b33dd7@meta.com>

On Wed Apr 15, 2026 at 7:49 AM PDT, Mykyta Yatsenko wrote:
> +	while ((prog = READ_ONCE(item->prog))) {
> +		if (!prog->sleepable)
> +			rcu_read_lock();
> +
> +		/*
> +		 * Per-prog recursion check to enable private stack.
> +		 * Skip if prog->active is not allocated, e.g.
> +		 * for dummy_bpf_prog used as a fallback placeholder
> +		 * by bpf_prog_array_delete_safe().
> +		 */
> +		if (likely(prog->active)) {
> +			if (unlikely(!bpf_prog_get_recursion_context(prog))) {
> +				bpf_prog_inc_misses_counter(prog);
> +				bpf_prog_put_recursion_context(prog);
> +				if (!prog->sleepable)
> +					rcu_read_unlock();
> +				item++;
> +				continue;
> +			}
> +		}

What is the point of running dummy_bpf_prog ?
You just checked that it's dummy and yet want it to burn cpu?

Once again, please de-claude it.
So much unnecessary indent.
Focus on keeping indent minimal.
Since claude cannot do it, it's on you.

pw-bot: cr


  reply	other threads:[~2026-04-16  1:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15 14:49 [PATCH bpf-next v10 0/6] bpf: Add support for sleepable tracepoint programs Mykyta Yatsenko
2026-04-15 14:49 ` [PATCH bpf-next v10 1/6] bpf: Add sleepable support for raw " Mykyta Yatsenko
2026-04-15 14:49 ` [PATCH bpf-next v10 2/6] bpf: Add bpf_prog_run_array_sleepable() Mykyta Yatsenko
2026-04-16  1:41   ` Alexei Starovoitov [this message]
2026-04-16 14:40     ` Alexei Starovoitov
2026-04-17 17:22       ` Mykyta Yatsenko
2026-04-20 15:46         ` Alexei Starovoitov
2026-04-15 14:49 ` [PATCH bpf-next v10 3/6] bpf: Add sleepable support for classic tracepoint programs Mykyta Yatsenko
2026-04-15 14:49 ` [PATCH bpf-next v10 4/6] bpf: Verifier support for sleepable " Mykyta Yatsenko
2026-04-15 14:49 ` [PATCH bpf-next v10 5/6] libbpf: Add section handlers for sleepable tracepoints Mykyta Yatsenko
2026-04-15 14:49 ` [PATCH bpf-next v10 6/6] selftests/bpf: Add tests for sleepable tracepoint programs Mykyta Yatsenko
2026-04-15 20:32   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHU7408DLITK.2DC76VINL2F7K@gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=kafai@meta.com \
    --cc=kernel-team@meta.com \
    --cc=memxor@gmail.com \
    --cc=mykyta.yatsenko5@gmail.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=yatsenko@meta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox