public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Emil Tsalapatis" <emil@etsalapatis.com>
Cc: "Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
	"bpf" <bpf@vger.kernel.org>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Eduard" <eddyz87@gmail.com>, "Song Liu" <song@kernel.org>
Subject: Re: [PATCH bpf-next v7 0/9] Introduce arena library and runtime
Date: Fri, 17 Apr 2026 11:21:33 -0700	[thread overview]
Message-ID: <DHVN02XJ88CO.2RKJLH02JAHI@gmail.com> (raw)
In-Reply-To: <DHVMLVAMJT7X.GMOA3L4111QN@etsalapatis.com>

On Fri Apr 17, 2026 at 11:03 AM PDT, Emil Tsalapatis wrote:
>>> libarena is different in that it's BPF code we distribute as source.
>>> Plus, the test runner is an example of how to set up the arena state.
>>> It's very little code and automatically identifies the selftests without
>>> having to explicitly enumerate them, so it's not extra maintenance burden.
>>> For followup patches it's been 0 LOC to either the libarena selftest or the
>>> test_progs test.
>>
>> I think what Kumar is saying is that we have only one runner in CI:
>> test_progs, so all libarena tests need to be covered by test_progs.
>
> In that case I misunderstood. I agree that everything should be tested
> by test_progs. There's currently the ASAN version of libarena missing,
> but we can add it and turn it off if the compiler doesn't support it.
>
> There is the secondary question: Do we want to have a standalone
> libarena runner in addition to the one in test_progs in the codebase?
> Imo we do, for the reasons above.

I think it's fine to have standalone libarena runner as well,
but it may bit rot, since CI won't be running it.

  reply	other threads:[~2026-04-17 18:21 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-12 17:45 [PATCH bpf-next v7 0/9] Introduce arena library and runtime Emil Tsalapatis
2026-04-12 17:45 ` [PATCH bpf-next v7 1/9] bpf: Allow instructions with arena source and non-arena dest registers Emil Tsalapatis
2026-04-12 19:54   ` Alexei Starovoitov
2026-04-12 17:45 ` [PATCH bpf-next v7 2/9] selftests/bpf: Add tests for non-arena/arena operations Emil Tsalapatis
2026-04-12 17:45 ` [PATCH bpf-next v7 3/9] selftests/bpf: Move bpf_arena_spin_lock.h to the top level Emil Tsalapatis
2026-04-12 19:31   ` Kumar Kartikeya Dwivedi
2026-04-17 16:07     ` Emil Tsalapatis
2026-04-12 17:45 ` [PATCH bpf-next v7 4/9] selftests/bpf: Move READ_ONCE/WRITE_ONCE macros to bpf_experimental.h Emil Tsalapatis
2026-04-12 19:33   ` Kumar Kartikeya Dwivedi
2026-04-17 16:06     ` Emil Tsalapatis
2026-04-17 16:21       ` Kumar Kartikeya Dwivedi
2026-04-17 16:38         ` Emil Tsalapatis
2026-04-12 17:45 ` [PATCH bpf-next v7 5/9] selftests/bpf: Add basic libarena scaffolding Emil Tsalapatis
2026-04-12 18:28   ` bot+bpf-ci
2026-04-12 18:31     ` Emil Tsalapatis
2026-04-12 17:45 ` [PATCH bpf-next v7 6/9] selftests/bpf: Add arena ASAN runtime to libarena Emil Tsalapatis
2026-04-12 18:28   ` bot+bpf-ci
2026-04-12 18:34     ` Emil Tsalapatis
2026-04-12 17:45 ` [PATCH bpf-next v7 7/9] selftests/bpf: Add ASAN support for libarena selftests Emil Tsalapatis
2026-04-12 17:45 ` [PATCH bpf-next v7 8/9] selftests/bpf: Add buddy allocator for libarena Emil Tsalapatis
2026-04-12 17:45 ` [PATCH bpf-next v7 9/9] selftests/bpf: Add selftests for libarena buddy allocator Emil Tsalapatis
2026-04-12 19:22 ` [PATCH bpf-next v7 0/9] Introduce arena library and runtime Kumar Kartikeya Dwivedi
2026-04-17 14:43   ` Emil Tsalapatis
2026-04-17 16:15     ` Kumar Kartikeya Dwivedi
2026-04-17 16:33       ` Emil Tsalapatis
2026-04-17 17:06         ` Alexei Starovoitov
2026-04-17 18:03           ` Emil Tsalapatis
2026-04-17 18:21             ` Alexei Starovoitov [this message]
2026-04-12 20:00 ` patchwork-bot+netdevbpf
2026-04-16 20:23 ` Matt Bobrowski
2026-04-16 20:31   ` Matt Bobrowski
2026-04-16 20:43     ` Song Liu
2026-04-17  5:59       ` Matt Bobrowski
2026-04-17 14:36         ` Emil Tsalapatis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DHVN02XJ88CO.2RKJLH02JAHI@gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=memxor@gmail.com \
    --cc=song@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox