Re: [PATCH bpf-next] selftests/bpf: remove string.h includes in bpf progs

["Alexei Starovoitov" <alexei.starovoitov@gmail.com>]

On Tue Apr 21, 2026 at 1:22 PM PDT, David Faust wrote:
> Sources for some BPF test programs currently include string.h, which
> is a glibc header and not a toolchain header.  Since there is no BPF
> glibc, this means it is the native system glibc string.h which gets
> included when building the test programs.
>
> In all cases the include is only necessary for the prototypes of
> non-builtin versions of memset, memcpy, etc., and in every case both
> clang and gcc already replace these with the compiler built-in versions
> and expand them inline.
>
> In the case of gcc this replacement happens after initial debuginfo is
> generated, which includes the calls to the glibc routines.  This means a
> BTF record for e.g. 'extern memset' is emitted, resulting in load
> failures like:
>
>   libbpf: BTF loading error: -22
>   ...
>   [26] FUNC memset type_id=1 Invalid func linkage

...

> -	memcpy(&val, keys, sizeof(val));
> +	__builtin_memcpy(&val, keys, sizeof(val));

This is not an option. It works for llvm because it inlines it for small sizes.
GCC should do the same.
For large sizes llvm will emit libcall to memset
that libbpf will error with "FUNC memset type_id=1 Invalid func linkage"
and that's a separate issue to deal with.

pw-bot: cr