Re: [PATCH bpf-next v9 01/11] selftests/bpf: Add BPF_STRICT_BUILD toggle

["Ricardo B. Marlière" <rbm@suse.com>]

On Wed Apr 29, 2026 at 12:13 PM -03, bot+bpf-ci wrote:
>> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
>> index 97ee61f2ade5..6094fe99b5f6 100644
>> --- a/tools/testing/selftests/bpf/Makefile
>> +++ b/tools/testing/selftests/bpf/Makefile
>> @@ -44,6 +44,12 @@ SKIP_LLVM	?=
>>  SKIP_LIBBFD	?=
>>  SKIP_CRYPTO	?=
>>
>> +# When BPF_STRICT_BUILD is 1, any BPF object, skeleton, test object, or
>> +# benchmark compilation failure is fatal. Set to 0 to tolerate failures
>> +# and continue building the remaining tests.
>> +BPF_STRICT_BUILD ?= 1
>> +PERMISSIVE := $(filter 0,$(BPF_STRICT_BUILD))
>> +
>>  ifeq ($(srctree),)
>>  srctree := $(patsubst %/,%,$(dir $(CURDIR)))
>>  srctree := $(patsubst %/,%,$(dir $(srctree)))
>
> Multiple reviewers (Sashiko AI and bot+bpf-ci@kernel.org) raised a concern
> in v5 that when permissive mode skips building .ko files, the
> $(TRUNNER_BINARY)-extras rsync target will fail fatally during out-of-tree
> builds (when O= is set) because TEST_KMOD_TARGETS are included in
> TRUNNER_EXTRA_FILES but the .ko files were never created.
>
> The rsync command lacks --ignore-missing-args flag to handle missing files:
>
> tools/testing/selftests/bpf/Makefile:$(TRUNNER_BINARY)-extras {
>     $(call msg,EXT-COPY,$(TRUNNER_BINARY),$(TRUNNER_EXTRA_FILES))
>     $(Q)rsync -aq $$^ $(TRUNNER_OUTPUT)/
> }
>
> According to the v6 changelog, this was addressed by adding
> --ignore-missing-args to the -extras rsync, but this fix does not appear
> in the current commit. Does the rsync command need --ignore-missing-args
> to prevent 'No such file or directory' errors when .ko files are missing
> in permissive mode during out-of-tree builds?

This patch only adds BPF_STRICT_BUILD/PERMISSIVE variables. The rsync
fix comes next in "[PATCH bpf-next v9 02/11] selftests/bpf: Fix
test_kmods KDIR to honor O= and distro kernels".

>
> Reference:
> https://lore.kernel.org/bpf/20260415211828.BFAFFC19424@smtp.kernel.org/
> Reviewer: Sashiko AI
> Date: Wed, 15 Apr 2026 21:18:28 +0000
>
>
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
>
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/25115689001