From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr2-f2.google.com (mail-wr2-f2.google.com [74.125.225.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB0324756A2 for ; Fri, 24 Jul 2026 23:34:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784936098; cv=none; b=TvQmdHnejWiRN5czJl31LyWGERrB554lI/5yA8X6URXr4mZxk2Ki4t39cm8Hapxt5xaeO4eByUTMFNKMpOaoD/GokMAC30qJB3nBKzS2gMNzMiGovmMiYMOnGHalfvArYqYyyzn7HFGNhfYifgR+8Tr7L2KLN815i3n1e74w6Fo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784936098; c=relaxed/simple; bh=CHOFKpN4PQ499iQVlSuJFWWe52WI91gJWBi9MYe+/Qc=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=Po4/pn0SwPk2g4fl9ABT7zO07nACUcn6DmpMpTNljWU5r86hjBg7GqVc06ayUA7IrKZG0Nb7MmwLWJQk/AIhwRacDyhY8QBAgvSP1unhvhb/E/IhSqGLtQc4m1t4VuU3qFaZcVDqa5SZv+fddGYCTM30PwXqBNZEDpT853vslrg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nFeV7mjH; arc=none smtp.client-ip=74.125.225.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nFeV7mjH" Received: by mail-wr2-f2.google.com with SMTP id ffacd0b85a97d-4730b8edae6so257750f8f.0 for ; Fri, 24 Jul 2026 16:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784936095; x=1785540895; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=hD1qzOwblf2DhkJIDvNTeZ3M9SYqPvy616a9XPVmkaE=; b=nFeV7mjHd+7Rhv1n/OAnbesDXZ58fd3U7HbjeD4WYEWL2D1ILbh+TJcBmovaR0ezLg lmUnflxzhV0lo+A/bIPImTr6s+vRN54noWwqVfYZuJKe3EOYd4GUoQP0Ji3Wiu/1q3P6 d6szG7txDspdZRXKgDyWyZJ8RgtXehB+IstJ0RVkpf6cJYbohebDuohaRYnn4d8wD32Y 6tKNqyzKN4dDBC5pcyt2ojKxLGDvW8m0bU3TO3yflG8fQfIJ6+aU29VsLVJwbnKHtkfY o6p+KpwRJjHh/8r8sFfcmKCBB8ntTeVfFYr0dPAx0WGZYghbgk2wtoxUJeI0qS0J9ElB hKDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784936095; x=1785540895; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hD1qzOwblf2DhkJIDvNTeZ3M9SYqPvy616a9XPVmkaE=; b=n+FgrHRfDzp8j4/C7DODgNckJtFEVcjdHoJG44uSEwEYeJgV6+qxU93YQ1omHGdEKF kg3F27D8WBpva0wjPBIw1/bEUtyMqazsUYzQE4K2Ms6/5bregmo9TTAcXzk3r0yQg1Ju UWdwMrA5wxnyOKBTBDQGNa/AE4loYkxMQt8g8iBacKkNrFwbEqndRxKD9zZeuxcKClhi VQ0h12nrTwpMkBcDqHNhK2h1frUzjaHUbH6jIKScnVI1HJTbXZlw0hQAknB9pGmr4kkX 2j4ZleE6cnY04lgPvb/stJJ1RP8B5ZS4qUAu3yBDJS6qcBhpbI79Rgwy26VarUWA8hrH S6zA== X-Forwarded-Encrypted: i=1; AHgh+Ro0AyKwebPeEtcNWpm3cIQzAeljHtJI6iqXKyMyi8E4aXZ9ydnUX6tayVC9VHmgN2GCZsg=@vger.kernel.org X-Gm-Message-State: AOJu0YyNRSniM/Uu6/OvMnsCw4oY4M5X0ygqhZZYsYtzAEw8DZ1VGeb4 AwTjAMWSFPPIqkC7JPzcZ/1EBxzbcHDaudahofIhZEZAX5HF+5Khx3P6 X-Gm-Gg: AR+sD12tkCrm+pnNOR9O4jzypg5InTuCfRzQ+qPHIimlLgiBqcZMoe+IhJ7by/P1AYZ 7njgU0EQIN5EJ/9aEIykm7lFG3TMRFuDtmvifQzKpXYZ1+Ino5QxAOiPahps18/z0UO/R8f1I55 9Eggv6Cm08/KCJTK4bDCh5i3YT60U40g4JGM46bhuRFw8K74p4sutca7dTh0ruSJgoN7W3WKUcM g/o3NwFsXzjuRrNVPORZMwhPhe0w6NHxnA6A31s+fKkhrbhL+y1lUzNV8V1m4bYdn4kLqrlgVoP DKyiSELG5BzqIZ5b1X0nOxw5ETyBsADtYBrXAmKowuhyojG2Jk3otxtx5Lwkiblv0mSgu3oornU tLX4waA1F+rvNVW0msoxLF8rVCHCSB0rwnRbaT6HRpIOi5aGcZ4u6ffBqU2RwinvSGS9PBtsRzV kNhc8TdOfVEDAXQGzxmPrSldgayn7+N0ibUfVQ5B0LRu+Ljas5PTCSNe2XyP66RpyMBtHWqs4jI RMY9cZ/yOnKlCRlmnVMWe9p/BRd+0iGctwsMdpfAJzd X-Received: by 2002:a05:600c:1c12:b0:496:b3a0:1cfe with SMTP id 5b1f17b1804b1-496b56f3994mr3482295e9.12.1784936094864; Fri, 24 Jul 2026 16:34:54 -0700 (PDT) Received: from localhost (nat-icclus-192-26-29-3.epfl.ch. [192.26.29.3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4957bfe07e1sm75012115e9.3.2026.07.24.16.34.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 16:34:54 -0700 (PDT) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sat, 25 Jul 2026 01:34:54 +0200 Message-Id: Cc: "James Clark" , "Andrii Nakryiko" , "Eduard Zingerman" , "Arnaldo Carvalho de Melo" , "Ihor Solodrai" , "Nathan Chancellor" , "Nick Desaulniers" , "Bill Wendling" , "Justin Stitt" , "Alexei Starovoitov" , "Daniel Borkmann" , "Martin KaFai Lau" , "Song Liu" , "Yonghong Song" , "Jiri Olsa" , "Emil Tsalapatis" , "Peter Zijlstra" , "Ingo Molnar" , "Mark Rutland" , "Alexander Shishkin" , "Ian Rogers" , "Adrian Hunter" , "Shuah Khan" , , , , , Subject: Re: [PATCH v4 0/4] tools/build: Allow versioning of all LLVM tools From: "Kumar Kartikeya Dwivedi" To: "Namhyung Kim" X-Mailer: aerc 0.21.0 References: <20260715-james-perf-llvm-version-v4-0-6dfdf984b435@linaro.org> In-Reply-To: On Sat Jul 25, 2026 at 1:31 AM CEST, Namhyung Kim wrote: > On Fri, Jul 24, 2026 at 07:19:45PM +0200, Kumar Kartikeya Dwivedi wrote: >> On Thu Jul 16, 2026 at 1:46 AM CEST, Namhyung Kim wrote: >> > Hello BPF folks, >> > >> > On Wed, Jul 15, 2026 at 03:53:47PM +0100, James Clark wrote: >> >> I ran into the build issue mentioned in the first commit, because usi= ng >> >> an option like LLVM=3D-15 is a documented way to build [1], but only >> >> some of the LLVM tools defined in tools/ support this. >> >> >> >> After fixing that, a lot of other tidyups fell out. I didn't go too f= ar, >> >> for example some selftests include tools/testing/selftests/lib.mk whi= ch >> >> reimplements some of the LLVM_SUFFIX stuff, but other selftests inclu= de >> >> tools/scripts/Makefile.include and I stopped before touching the form= er. >> >> Some other non build scripts hard code toolchains and I didn't touch >> >> those either, this change is only focused on things that already >> >> include Makefile.include. >> >> >> >> [1]: Documentation/kbuild/llvm.rst >> >> >> >> Signed-off-by: James Clark >> >> --- >> >> Changes in v4: >> >> - Drop "tools/build: selftests: Allow versioning LLVM lld", clang >> >> already picks the correct sibling lld version. (Sashiko) >> >> - Link to v3: https://lore.kernel.org/r/20260715-james-perf-llvm-vers= ion-v3-0-8854bfe5af7e@linaro.org >> >> >> >> Changes in v3: >> >> - Add warning for empty $USE_LD >> >> - Use $HOSTREADELF in bpf Makefile >> >> - Rebase on v7.2-rc3 >> >> - Link to v2: https://lore.kernel.org/r/20260518-james-perf-llvm-vers= ion-v2-0-f12cc4f031d8@linaro.org >> >> >> >> Changes in v2: >> >> - Fix selftests/bpf build. LLD needs to take the full path to be used >> >> with -fuse-ld=3D >> >> - Link to v1: https://lore.kernel.org/r/20260514-james-perf-llvm-vers= ion-v1-0-6cac1a9a4c8d@linaro.org >> >> >> >> --- >> >> James Clark (4): >> >> tools/build: Allow versioning of all LLVM tools defined in Make= file.include >> >> tools/build: Indent if else blocks >> >> tools/build: Allow versioning LLVM readelf >> >> tools/build: selftests: Remove some duplicate toolchain definit= ions >> >> >> >> tools/bpf/resolve_btfids/Makefile | 3 -- >> >> tools/lib/api/Makefile | 4 -- >> >> tools/lib/bpf/Makefile | 8 ++-- >> >> tools/lib/subcmd/Makefile | 4 -- >> >> tools/lib/symbol/Makefile | 4 -- >> >> tools/perf/Makefile.perf | 7 ---- >> >> tools/scripts/Makefile.include | 77 ++++++++++++++++++++------= ---------- >> >> tools/testing/selftests/bpf/Makefile | 1 - >> >> 8 files changed, 46 insertions(+), 62 deletions(-) >> > >> > Are you ok with this change and going through perf tree? >> > >> >> Sorry for the delay, yes, feel free to take it through your tree. > > Thanks, can I take it as your Acked-by? > Sure. Acked-by: Kumar Kartikeya Dwivedi > Namhyung