From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2326F1A5BAE for ; Fri, 4 Sep 2026 12:34:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788525298; cv=none; b=snpWHeaZsDjWvgIYFz1phiGPheSbSz9N4HeZ4fT2FhgZ0IuBw1icicjBzWeOz/tH4aWqUPMP/J3EM9jb6bYRW5UJAfj9XufH3q5cilBgfBomJaovgfDVjLhjlWHFk2klz7Lie7Ed0jUThh5UQxdMrWcS0x6sxYVKOoKqmGensNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788525298; c=relaxed/simple; bh=xioRLTaKtQKL260SUtxj34bS0YbzGsBJwB6PF9pf6rY=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=Q7cN2Q9/g1X2pLaLix4LR+OBiBqBSrHR54Jr55oxhTLog5P/xW8QjTsL/st7v+mGDVdOqQMOJbdRo6xpmtdLY1xu4XMk0+RDgvTroTWg1n2NMHnZKRirYri0cHXg5QmVxeqzIwmBP8VAmL6DiyGVEYKxjY2u2Qmkh3P+JY0RIx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VHXMPxtq; arc=none smtp.client-ip=209.85.160.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VHXMPxtq" Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-5302b692c8eso10521261cf.2 for ; Fri, 04 Sep 2026 05:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1788525295; x=1789130095; darn=vger.kernel.org; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=paqRFyHFvX+txrKAZySjILGu4egNb8auPfRKWSQjZAM=; b=VHXMPxtqBCDRzTjtUe6mD5PCszf6l5ot3oTcufOcoijf0K2UHvyVD86IN5YRDej8Y5 y4m5DPxSr4fylCwFVPCSegEm+tboEM8iZdjx/7GGNCtaV8mskIktZf200nIB7FHhGdj+ dFV2FQKLekWZ0ieXUc/ornS7EoJ2Xwne+9FZNBcaGDtUPDJNKJF0qk8Q2/usj2BI++6u 6pNeawZ0+EwpIZRizNyDEJzk2Dg5X31pCavkF8CMTrNbkswdK7kwZzR7LC/1gfc3UfHk 3uDCUvLfwyZ++0gB4rcO9jvXeSawxugywlkJBwnmudhtXr8Qi+PyfHraMilU38Oq+Wsp g0Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788525295; x=1789130095; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-type:content-transfer-encoding:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=paqRFyHFvX+txrKAZySjILGu4egNb8auPfRKWSQjZAM=; b=fPaCWrt7wNBABMavahnccSuM01p7ovjU91kjSVAXktvP99Lc07yew3lIJy4hidU5BV fLTkUl6/GneJE4XGLG9Q1CF4VP8BF50sD+wewhJc3xtcRtjBnl+2FSVs0WNFKNAcKmhV YQa2Gb4GP9E2LR8zrUVt+pSlZ0ekTQPYwmEN44HfI5OxTqEUQX+DIwQTnVj1aOc9A5dg BibDju/1KodvLCDxcZv+CY15UE6QWBJWVUYhwCprbgpEdD78MX3bqMCSm0AMWIfF1YrG OVtyDEBYPfwphUiIlEcz4ansWZMfP7yEF19j34tPJjoKdrMTdFZoPz2yu4ExzC83NMcK WAyg== X-Forwarded-Encrypted: i=1; AKwUvByWWkXPkEQu+KOcsSLXw/A0iYON6WrPqfaOhdBUspuxjmyeR1Izutjz2clYfGMkrVG7Ijg=@vger.kernel.org X-Gm-Message-State: AFuF++nlPxbGI3g4XFkhPDmKNrZ/1viOChOiooWEIJWfbuZ+/7/8PK3p iwfuj45mDRrx7NiImCa0K0O8XEoBknn2nnPH/7ni82C/LcIavfkDvvbo X-Gm-Gg: AYBFou1Qrews/qZPbIMsifpd2evKQERqc0ttlQNd/nqFc9FPJsf3FLXte1U6ale9XNw Un6oDyUMCanek3u0sY7e94+hizyNxUcMrkXJRf3gK8lEL3HUtHYRt4ZVungnsPGUYd8ENkkFujR 9j/RKepusp1SkPrz1yIUVMwSteP8fZiK9PPMY8Tg8sMEdhuE0ixykKXA9gdmWoYEJf0mb3Mjfp5 8W2MGdUcfC5wKG8kW3fyOqiNRMg5A8ffffbGepOWo/W/ON0/U2XrpsbyTlHcjmxKsnNTYnyJkgy YyLrkURScviBf+YuEAUyAI1Mu35LYbWz2RaQs4UtDpwROE41ZtrdmsQFr7/qVgKAguBuMPz6KJS jQrD928I4sBiA0qYRZEj97HykwibgS7Vy0hBH4wMf/yXSpRwF6LxJoajGnujfPBT+OfYYczcfhZ 5I5MR7V8DDLdGyrQWFGCdrYCwyqPerOQxZPc4rxVdV7i9Vm7XOp9jxdiXoMSz/KT143A== X-Received: by 2002:a05:622a:50d:b0:530:42e5:f3a4 with SMTP id d75a77b69052e-53054a0db44mr57968521cf.45.1788525294879; Fri, 04 Sep 2026 05:34:54 -0700 (PDT) Received: from localhost ([2600:4040:9399:4000:e553:72e5:7d37:c7ef]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-910406976a5sm19170816d6.39.2026.09.04.05.34.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Sep 2026 05:34:54 -0700 (PDT) Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 04 Sep 2026 08:34:52 -0400 Message-Id: Cc: "Aleksandr Loktionov" , "Alexei Lazar" , "Alexei Starovoitov" , "Allison Henderson" , "Antonio Quartulli" , "Anubhav Singh" , "Bobby Eshleman" , "Boris Pismenny" , , "Carolina Jubran" , "Chris Mi" , "Cosmin Ratiu" , "Daniel Borkmann" , "Daniel Zahka" , "David Wei" , "Doruk Tan Ozturk" , "Dragos Tatulea" , "Gal Pressman" , "Jacob Keller" , "Jesper Dangaard Brouer" , "Jianbo Liu" , "John Fastabend" , "Kees Cook" , "Lama Kayal" , "Leon Romanovsky" , "open list" , , , "Mark Bloch" , "Matthieu Baerts (NGI0)" , "Patrisious Haddad" , "Petr Machata" , "Raed Salem" , "Rahul Rameshbabu" , "Richard Gobert" , "Saeed Mahameed" , "Shuah Khan" , "Shuah Khan" , "Simon Horman" , "Stanislav Fomichev" , "Stanislav Fomichev" , "Willem de Bruijn" , "Willem de Bruijn" Subject: Re: [PATCH net-next V3 13/15] selftests: drv-net: gro: Extract shared helpers into gro_lib.py From: "Daniel Zahka" To: "Tariq Toukan" , "Andrew Lunn" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , , "Paolo Abeni" , "Sabrina Dubroca" X-Mailer: aerc 0.21.0-threadmapfix References: <20260903085215.3691657-1-tariqt@nvidia.com> <20260903085215.3691657-14-tariqt@nvidia.com> In-Reply-To: <20260903085215.3691657-14-tariqt@nvidia.com> On Thu Sep 3, 2026 at 4:52 AM EDT, Tariq Toukan wrote: > From: Cosmin Ratiu > > Bits and pieces of gro.py are needed by a second test file: > - dmac resolution > - the ethtool/sysfs feature dance > - the HW GRO setup logic > - the gro binary invocation > - the retry loop > > Move them to gro_lib.py, installed via TEST_FILES (like psp_lib.py). > > hw/gro_hw.py keeps its own copies for now since they diverged. > > Signed-off-by: Cosmin Ratiu > Reviewed-by: Dragos Tatulea > Signed-off-by: Tariq Toukan > --- > tools/testing/selftests/drivers/net/Makefile | 1 + > tools/testing/selftests/drivers/net/gro.py | 200 ++---------------- > .../testing/selftests/drivers/net/gro_lib.py | 194 +++++++++++++++++ > 3 files changed, 217 insertions(+), 178 deletions(-) > create mode 100644 tools/testing/selftests/drivers/net/gro_lib.py > Conflicts with: f225a7317c18 ("selftests: drv-net: split gro.py into one test per coalescin= g mode") I will take a look at the other patches now in case I can provide any feedback before reposting.