Re: [PATCH bpf-next v2 1/2] bpf: Verify global subprogs in each sleepability context

["Alexei Starovoitov" <alexei.starovoitov@gmail.com>]

On Fri Sep 4, 2026 at 10:12 PM PDT, Kumar Kartikeya Dwivedi wrote:
>
> Record whether each global subprogram is called with either in_sleepable
> value and verify it once for every observed value.
...

> Since a global subprogram may now be verified twice, accumulate both passes
> in subprog_info[].insns_total.

Only after reading the patch carefully I realized that above is saying 'may'.
Just by reading commit log it sounds that all global progs are now verified twice.

Please reword to make it clear that glob progs are verifier in the specific
context when it's actually reachable.

>  
> -/* Check if we're in a sleepable context. */
> +/*
> + * This predicate is the inverse of in_rcu_cs(): non-sleepable programs and
> + * every condition that prevents sleeping also provide RCU protection. Global
> + * subprog verification relies on this equivalence to represent the caller's
> + * execution context using only the in_sleepable bit.
> + */
>  static inline bool in_sleepable_context(struct bpf_verifier_env *env)
>  {
>  	return !env->cur_state->active_rcu_locks &&

Since it is !in_rcu_cs() let's make it so in the code.

pw-bot: cr