BPF List
 help / color / mirror / Atom feed
From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Yun Lu" <luyun_611@163.com>, <ast@kernel.org>,
	<daniel@iogearbox.net>, <andrii@kernel.org>, <eddyz87@gmail.com>,
	<memxor@gmail.com>, <martin.lau@linux.dev>, <song@kernel.org>,
	<yonghong.song@linux.dev>, <jolsa@kernel.org>,
	<emil@etsalapatis.com>, <ihor.solodrai@linux.dev>
Cc: <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next 1/2] bpf: Fix task work round ownership during cancellation
Date: Fri, 18 Sep 2026 17:54:36 +0000	[thread overview]
Message-ID: <DLIMVC4MY6XT.22U1NMBVLDVM@gmail.com> (raw)
In-Reply-To: <20260918080014.54012-2-luyun_611@163.com>

On Fri Sep 18, 2026 at 8:00 AM UTC, Yun Lu wrote:
>  struct bpf_task_work_ctx {
>  	enum bpf_task_work_state state;
>  	refcount_t refcnt;
> +	/*
> +	 * References to task/prog/work in the current scheduling round.  The
> +	 * STANDBY -> PENDING transition serializes initialization from zero.
> +	 */
> +	refcount_t round_refs;
>  	struct callback_head work;
>  	struct irq_work irq_work;
> +	struct irq_work cancel_irq_work;
> +	struct irq_work destroy_irq_work;

This is overkill. Find a different way to fix it.

pw-bot: cr

  reply	other threads:[~2026-09-18 17:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18  8:00 [PATCH bpf-next 0/2] bpf: Fix task work round ownership race Yun Lu
2026-09-18  8:00 ` [PATCH bpf-next 1/2] bpf: Fix task work round ownership during cancellation Yun Lu
2026-09-18 17:54   ` Alexei Starovoitov [this message]
2026-09-21 10:22     ` luyun
2026-09-18  8:00 ` [PATCH bpf-next 2/2] selftests/bpf: Add task work round ownership race test Yun Lu
2026-09-18  8:13   ` sashiko-bot
2026-09-18  9:12   ` bot+bpf-ci
2026-09-18 16:50 ` [PATCH bpf-next 0/2] bpf: Fix task work round ownership race Mykyta Yatsenko
2026-09-18 17:17   ` Mykyta Yatsenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLIMVC4MY6XT.22U1NMBVLDVM@gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=jolsa@kernel.org \
    --cc=luyun_611@163.com \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox