From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f12.google.com (mail-pj2-f12.google.com [74.125.227.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1FB53DD854 for ; Sun, 20 Sep 2026 16:21:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.140 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789921308; cv=none; b=hTnOT4aD9TP+0iCVH8UsVoLmyz2I56WdwGtVsaa7bzbk5/GnUsIxL7VkhrDPRlsCJnjirKnwsGFAmhQMxyrHIxWz0ETdkDWRAEr+jvvcTUuN3kdQtcwqZNBaRa81mOQZaAw5cxnzWBLMMNu+8nunJfOy47aIhtx+SAeasDm+hoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789921308; c=relaxed/simple; bh=qfdM3YubCe2IP79evjGQNlSp/HU4IyfWbW9l+cBm2Rg=; h=Content-Type:Date:Message-Id:Subject:From:To:Cc:In-Reply-To: References:MIME-Version; b=op3sOcROWZn3QpOea87xdOdrjSeq9Gg3+O6VUPDt2I+J9j0Fm6CdhurOIBOGz+8hAhSAc4X4LH5pgSItRBQZcvXuE+xf4rYpWPPgPUNdqcCdyz+N0KukgtcWKnZQbaLqcSyE44T9jfho/uLO4p3aaISd6zNv5+o//DRnV9nrrRg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qGepoum3; arc=none smtp.client-ip=74.125.227.140 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qGepoum3" Received: by mail-pj2-f12.google.com with SMTP id 98e67ed59e1d1-396ccafb74fso2298934a91.3 for ; Sun, 20 Sep 2026 09:21:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789921306; x=1790526106; darn=vger.kernel.org; h=mime-version:content-transfer-encoding:references:in-reply-to:cc:to :from:subject:message-id:date:content-type:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Gy5ssaabRSlN5kBFNvs8mh80/gy44esWLyC1RJAbEbs=; b=qGepoum3EieqrlPF7DutwuW8Fc2VyWKRJkCu/M+PyxqYxN6PISB4Ba41CAQy6SUvIt ZBYqjtYi/jgBvXej7PPpe3izlR/z0V8yk3OlEb3Qj4CbY2wU63Neui7mte80/EVqefEA hEE6gDxLfcLdr0Ij4bzCVh8G7WoDDDaLJ63wpCbkUAyGdD1WU5E0wx2BS92ELIw+2/fj I091/bi1WcMT3RVFM26y0lq5orT0ExYCqW9pxZ24hk+bxVEB9OfEoOoRKtMtXTKB+O/j OLSyWbQvrCuyAT46+lXIfj4g7cD8HcqWTtuh8ofAeZjsfdvFs4R0k3c2Mam5uZ88/fO5 +Stw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789921306; x=1790526106; h=mime-version:content-transfer-encoding:references:in-reply-to:cc:to :from:subject:message-id:date:content-type:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Gy5ssaabRSlN5kBFNvs8mh80/gy44esWLyC1RJAbEbs=; b=V55Jsu/fKX+XbUlTrIJv7ro57v2OSfwFI7f+KqPdvaGa3TIQBnWT5vukooonRNSpR6 H+vznDlEJhIUCLn/cHSwt4hlJm9LZgVbdXxPTG2Fbt0alIL3dZhwD6kEAlFfkrCYMch8 /r1WiHVAm2NvCz46IF0BX0S3OPfQMEZZZPEFy14zDZ/ySUKDwRkhVrOOP0Kd/LCW3ns4 HwrvOVQCxJzkXpQdLwRIHqVkWe4eeT/LQs5nMYx5MN6Ezl7a9uFT+d2j2x0ubiUGo6aQ RuV/p1MPFisKEUZ0qzisHVWs2FIrs/QXoxjLvVE1R5qPHhVaFcKjyi5YhyWXscbnKJxW RAZw== X-Forwarded-Encrypted: i=1; AKwUvBwYbuoz/SlLZayyTG6ixm0qyUXLHsq3TQ/d0gLABMnONh//tzjc78Tzbf/TkynJrzXIeuM=@vger.kernel.org X-Gm-Message-State: AFuF++kkmid2rjME7quLGYPlxRPJzq9ONcuEN3gC6Sq20/2K//xxKiUE 7Y1v5yL0QBWzFJSQEl2V378U0NfGqcpPr02aifONIzk3/A4mPZXMH8NF X-Gm-Gg: AYBFou2az5WPfy2vtugXO+xRT1UmgdboYnYPcnvo2SdoTCTMNPCy8i4rbO9zXpMq4mX HiHm1yfkBacGGNNrZSivQGXpEYxyKlac7wTx+zBPX+bimXLkyhC3qtpW/G0+8BZqdEMgWJJrGjT ai5bcYocfvG9lJ6JhTO7jHRsNNtFcTQKyVFpN2M2xGMjF3uc8xwcZ0xWDYwW+caHiH9qCGh0CU3 GseIvDUAizwGjCssOzzWH4ScQdOo9aLLloS2DtjPoMU/eqUDv0enm4eMSVl5E2mb4k4jxNSKsdS VKRVtq08KsYFGG6c6JCqht99Ye/Chg2rcKL8Sqbo0vRmzhmFm3HRgO6mZkvagcwhbqBSkNcTAdG MMW5OrS0QfIMBTlAHMV4twUEJc1wwks//ncmHhn9pCe6VOkZkY55FGJiJZYjJag/PBcRh9CsUiL AnUUpCpoOPmXfJTMQCnykNClSm0wUhaEatgWiYvaQnBFEQjLn4aB7F5CLLcUEXcSUiIN5rXrvEG aO+/D2bdM2WEZOw+opp1qyVqZ7qaKhTnRRGXpNXyZbFaS0c2X8CmkJJvfFhqKW4BZ9HBumZD8Dn N+Xx X-Received: by 2002:a17:90b:1647:b0:39e:4498:4863 with SMTP id 98e67ed59e1d1-39e54f4187emr17716173a91.10.1789921306000; Sun, 20 Sep 2026 09:21:46 -0700 (PDT) Received: from localhost ([153.61.198.244]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a03bcecdd2sm1495785a91.1.2026.09.20.09.21.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Sep 2026 09:21:45 -0700 (PDT) Content-Type: text/plain; charset=UTF-8 Date: Sun, 20 Sep 2026 16:21:44 +0000 Message-Id: Subject: Re: [PATCH bpf 1/2] bpf: Zero-fill other CPUs when BPF_F_CPU creates a per-cpu hash element From: "Alexei Starovoitov" To: "Donggeun Yoo" , Cc: , , , , , , , , , , , In-Reply-To: <20260920093153.439743-2-donggeunyoo.kernel@gmail.com> References: <20260920093153.439743-1-donggeunyoo.kernel@gmail.com> <20260920093153.439743-2-donggeunyoo.kernel@gmail.com> X-Mailer: mkdraft (claude review draft; edit before sending) Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sun, Sep 20, 2026 at 06:31 PM Donggeun Yoo wrote: > Fixes: c6936161fd55 ("bpf: Add BPF_F_CPU and BPF_F_ALL_CPUS flags support for percpu_hash and lru_percpu_hash maps") > Signed-off-by: Donggeun Yoo Pls cc Leon on respin. [...] > @@ -1056,12 +1056,12 @@ static void pcpu_init_value(struct bpf_htab *htab, void __percpu *pptr, > * known initial values for cpus other than current one > * (onallcpus=false always when coming from bpf prog). > */ > - if (!onallcpus) { > - int current_cpu = raw_smp_processor_id(); > + if (!onallcpus || (map_flags & BPF_F_CPU)) { > + int init_cpu = onallcpus ? map_flags >> 32 : raw_smp_processor_id(); The comment above covers only the bpf prog case now. Pls update it, but one short sentence about BPF_F_CPU is enough. What you proposed in reply to the bot is too verbose. pw-bot: cr