From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Eric Biggers" <ebiggers@kernel.org>
Cc: <sashiko-reviews@lists.linux.dev>, <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v4] bpf: crypto: Use AES-CBC and AES-ECB libraries
Date: Thu, 24 Sep 2026 02:18:28 +0000 [thread overview]
Message-ID: <DLN6PUF2FMLF.NU2U8L9V0XWH@gmail.com> (raw)
In-Reply-To: <20260923050134.GE42709@sol>
On Wed Sep 23, 2026 at 5:01 AM UTC, Eric Biggers wrote:
>
> Module code can only be called directly by module code, not built-in
> code. So CONFIG_CRYPTO_LIB_AES=m && CONFIG_BPF_CRYPTO=y cannot work;
> you'd get a linker error. For a module to offer these kfuncs they would
> either need to be their own module (e.g. bpf_crypto.ko), or else merged
> into the module of the underlying functions (libaes.ko, though again, in
> practice libaes is usually built-in anyway for other reasons).
ok. I feel it's better to go back to v1 approach:
select CRYPTO_LIB_AES_CBC
select CRYPTO_LIB_AES_ECB
with no prompt.
That will keep kfuncs on every BPF_SYSCALL kernel without a bpf_crypto.ko
and without moving the kfuncs into libaes.
Another alternative is:
depends on CRYPTO_LIB_AES=y && CRYPTO_LIB_AES_CBC && CRYPTO_LIB_AES_ECB
but select is imo better.
next prev parent reply other threads:[~2026-09-24 2:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 3:27 [PATCH bpf-next v4] bpf: crypto: Use AES-CBC and AES-ECB libraries Eric Biggers
2026-09-23 3:37 ` sashiko-bot
2026-09-23 4:02 ` Alexei Starovoitov
2026-09-23 4:11 ` Eric Biggers
2026-09-23 4:15 ` Alexei Starovoitov
2026-09-23 4:21 ` Eric Biggers
2026-09-23 4:55 ` Alexei Starovoitov
2026-09-23 5:01 ` Eric Biggers
2026-09-24 2:18 ` Alexei Starovoitov [this message]
2026-09-23 4:22 ` bot+bpf-ci
2026-09-23 4:55 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLN6PUF2FMLF.NU2U8L9V0XWH@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=ebiggers@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox