BPF List
 help / color / mirror / Atom feed
From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Emil Tsalapatis" <emil@etsalapatis.com>, <bpf@vger.kernel.org>
Cc: <andrii@kernel.org>, <eddyz87@gmail.com>, <memxor@gmail.com>,
	<daniel@iogearbox.net>
Subject: Re: [PATCH bpf-next v4 2/8] bpf: Associate arena pages with their mapping
Date: Fri, 16 Oct 2026 02:02:42 +0000	[thread overview]
Message-ID: <DM5W5RGVPBAW.2F70WVQ24HT6W@gmail.com> (raw)
In-Reply-To: <20261014233442.8392-3-emil@etsalapatis.com>

On Wed, Oct 14, 2026 at 11:34 PM Emil Tsalapatis <emil@etsalapatis.com> wrote:
> Associate arena backing pages with the arena's private mapping and set
> their page offsets. This allows the fault handler to delegate user PTE
> installation to generic MM code, which is itself useful for avoiding
> races with kfunc-related arena operations.

arena_vm_fault() returns vmf->page and finish_fault() installs the pte
today. That doesn't need page->mapping. VM_FAULT_LOCKED doesn't either.
tcmu_vma_fault() returns it for alloc_page()-ed pages.
mm folks were removing page->mapping and index from drivers. See
commit 6cdef2ddce2b ("fb_defio: do not use deprecated page->mapping, index fields").

[...]
> +/* Arena pages are not page-cache entries and must not be evicted by MM. */
> +static bool arena_release_folio(struct folio *folio, gfp_t gfp)
> +{
> +	return false;
> +}

The only place that looks at folio->mapping because of VM_FAULT_LOCKED
is PageHWPoison() branch in __do_fault().
If that's the reason for this patch then check PageHWPoison() in
arena_vm_fault() and return VM_FAULT_HWPOISON.
Drop this patch.

  parent reply	other threads:[~2026-10-16  2:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14 23:34 [PATCH bpf-next v4 0/8] bpf: Fix arena memory incoherence Emil Tsalapatis
2026-10-14 23:34 ` [PATCH bpf-next v4 1/8] bpf: Use mapping tree to zap arena VMAs Emil Tsalapatis
2026-10-15  0:33   ` bot+bpf-ci
2026-10-15 15:02     ` Emil Tsalapatis
2026-10-16  2:02   ` Alexei Starovoitov
2026-10-14 23:34 ` [PATCH bpf-next v4 2/8] bpf: Associate arena pages with their mapping Emil Tsalapatis
2026-10-15  0:01   ` sashiko-bot
2026-10-15 15:15     ` Emil Tsalapatis
2026-10-16  2:02   ` Alexei Starovoitov [this message]
2026-10-14 23:34 ` [PATCH bpf-next v4 3/8] bpf: arena: Stop deferred frees before map teardown Emil Tsalapatis
2026-10-14 23:34 ` [PATCH bpf-next v4 4/8] bpf: Update is_range_tree_set to work for consecutive ranges Emil Tsalapatis
2026-10-14 23:34 ` [PATCH bpf-next v4 5/8] bpf: Track availability information for ranges in range tree Emil Tsalapatis
2026-10-14 23:34 ` [PATCH bpf-next v4 6/8] bpf: Fix arena race between page free and alloc leading to incoherency Emil Tsalapatis
2026-10-16  2:02   ` Alexei Starovoitov
2026-10-14 23:34 ` [PATCH bpf-next v4 7/8] bpf: Synchronize arena page faults with page freeing Emil Tsalapatis
2026-10-15  0:33   ` bot+bpf-ci
2026-10-15 15:18     ` Emil Tsalapatis
2026-10-16  2:02   ` Alexei Starovoitov
2026-10-14 23:34 ` [PATCH bpf-next v4 8/8] selftests/bpf: Add arena allocation race tests Emil Tsalapatis
2026-10-14 23:52   ` sashiko-bot
2026-10-16  0:03 ` [PATCH bpf-next v4 0/8] bpf: Fix arena memory incoherence Emil Tsalapatis
2026-10-16  0:04   ` Emil Tsalapatis
2026-10-16  2:03 ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5W5RGVPBAW.2F70WVQ24HT6W@gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=emil@etsalapatis.com \
    --cc=memxor@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox