From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Ihor Solodrai" <ihor.solodrai@linux.dev>,
<bot+bpf-ci@kernel.org>, <bpf@vger.kernel.org>
Cc: <daniel@iogearbox.net>, <andrii@kernel.org>, <eddyz87@gmail.com>,
<memxor@gmail.com>, <yonghong.song@linux.dev>,
<martin.lau@kernel.org>, <mason@kernel.org>
Subject: Re: [PATCH bpf-next 2/3] bpf: Reject unwind_goto and unwind_exit in offloaded progs
Date: Thu, 22 Oct 2026 04:51:39 +0000 [thread overview]
Message-ID: <DMB3IDSRNEC7.1SYPQ5OXG7QR3@gmail.com> (raw)
In-Reply-To: <1ffe4765-ce81-4ff6-a483-e978dce5b234@linux.dev>
On Tue, Oct 20, 2026 at 07:23 PM Ihor Solodrai <ihor.solodrai@linux.dev> wrote:
> But I don't think we should remove "nit" passes from the review bots.
>
> If people don't read commit messages carefully, and review bots don't
> either, then we are increasing the amount of sloppy or outright
> incorrect claims in the git history.
An incorrect claim in the commit log is not a nit. Bots should keep
reading the logs and keep reporting those.
The problem is that a nit is delivered the same way as a bug.
The bot said "Code looks correct" and "This isn't a bug in the code",
ended the mail with "Please fix the bug or email reply why it's not a bug"
and turned ai-review and PR summary checks red in patchwork.
> And also what's the cost of a respin with a bot fixing a bot-detected
> nit? 2 minutes? 5?
I could live with nits if they were like comments on github PR
that are easy to ignore or one click 'accept the suggestion' button,
but here we're spaming the list and people already make fun
of 'This isn't a bug...' opening.
next prev parent reply other threads:[~2026-10-22 4:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-20 23:19 [PATCH bpf-next 0/3] bpf: Fixes for unwind_goto and unwind_exit Alexei Starovoitov
2026-10-20 23:19 ` [PATCH bpf-next 1/3] bpf: Make unwind_exit of an exception callback exit in JITs Alexei Starovoitov
2026-10-20 23:19 ` [PATCH bpf-next 2/3] bpf: Reject unwind_goto and unwind_exit in offloaded progs Alexei Starovoitov
2026-10-20 23:43 ` bot+bpf-ci
2026-10-21 0:08 ` Alexei Starovoitov
2026-10-21 2:23 ` Ihor Solodrai
2026-10-22 4:51 ` Alexei Starovoitov [this message]
2026-10-20 23:19 ` [PATCH bpf-next 3/3] selftests/bpf: Test unwind_exit of an exception callback Alexei Starovoitov
2026-10-21 0:10 ` [PATCH bpf-next 0/3] bpf: Fixes for unwind_goto and unwind_exit patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMB3IDSRNEC7.1SYPQ5OXG7QR3@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=martin.lau@kernel.org \
--cc=mason@kernel.org \
--cc=memxor@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox