From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Eduard Zateev" <hackerowskiy@gmail.com>, <bpf@vger.kernel.org>
Cc: <daniel@iogearbox.net>, <andrii@kernel.org>, <eddyz87@gmail.com>,
<memxor@gmail.com>, <martin.lau@linux.dev>, <song@kernel.org>,
<yonghong.song@linux.dev>, <jolsa@kernel.org>,
<emil@etsalapis.com>, <ihor.solodrai@linux.dev>,
<shuah@kernel.org>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH] libbpf: fix symbol resolution without .symtab
Date: Fri, 23 Oct 2026 15:59:10 +0000 [thread overview]
Message-ID: <DMCCC0KHY4VC.2O9M91KEVRW0J@gmail.com> (raw)
In-Reply-To: <20261023141040.249597-1-hackerowskiy@gmail.com>
On Fri, Oct 23, 2026 at 07:10 AM Eduard Zateev <hackerowskiy@gmail.com> wrote:
> -TEST_GEN_FILES += $(TEST_KMODS) liburandom_read.so urandom_read sign-file uprobe_multi
> +TEST_GEN_FILES += $(TEST_KMODS) liburandom_read.so urandom_read sign-file uprobe_multi \
> + uprobe_multi_stripped.so
The test will fail in test_progs-no_alu32 and test_progs-cpuv4.
cd_flavor_subdir() does chdir() into no_alu32/ and cpuv4/ and only
RUNNER_EXTRA_FILES are copied there. uprobe_multi_stripped.so is not
in that list, so elf_open("./uprobe_multi_stripped.so") returns -ENOENT
and the first ASSERT_OK_PTR() fails.
'make test_progs' won't build it either.
> + if (!ASSERT_OK_PTR(link, "attach_uprobe_multi_stripped")) {
> + link = NULL;
> + goto cleanup;
> + }
> + bpf_link__destroy(link);
> + link = NULL;
All three 'link = NULL' are dead code. Nothing reads it afterwards.
pw-bot: cr
prev parent reply other threads:[~2026-10-23 15:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 14:10 [PATCH] libbpf: fix symbol resolution without .symtab Eduard Zateev
2026-10-23 14:28 ` sashiko-bot
2026-10-23 15:59 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMCCC0KHY4VC.2O9M91KEVRW0J@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapis.com \
--cc=hackerowskiy@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=jolsa@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox