BPF List
 help / color / mirror / Atom feed
From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Wang Yibo" <szwyb123@gmail.com>, <bpf@vger.kernel.org>
Cc: "Andrii Nakryiko" <andrii@kernel.org>
Subject: Re: [PATCH bpf-next 2/3] selftests/bpf: name the failing registration in bpf_testmod_init
Date: Sun, 25 Oct 2026 01:24:26 +0000	[thread overview]
Message-ID: <DMDIZDAS0MXY.3SBEZOHWHM0V8@gmail.com> (raw)
In-Reply-To: <20261022080500.100-3-szwyb123@gmail.com>

On Wed, Oct 21, 2026 at 05:07 PM Wang Yibo <szwyb123@gmail.com> wrote:
> +#define TRY(expr)							\
> +	do {								\
> +		ret = (expr);						\
> +		if (ret < 0) {						\
> +			pr_err("%s: %s failed, ret %d\n",		\
> +			       __func__, #expr, ret);			\
> +			return ret;					\
> +		}							\
> +	} while (0)

pls no macros with hidden 'return'.

I also don't feel that the whole thing (patch 1 and the rest) is necessary.

pw-bot: cr

  reply	other threads:[~2026-10-25  1:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22  0:06 [PATCH bpf-next 0/3] Add diagnostics for kfunc registration failures and jit subtest skips Wang Yibo
2026-10-22  0:07 ` [PATCH bpf-next 1/3] bpf: report kfunc sets that fail BTF sanity check Wang Yibo
2026-10-22  0:28   ` bot+bpf-ci
2026-10-22  0:07 ` [PATCH bpf-next 2/3] selftests/bpf: name the failing registration in bpf_testmod_init Wang Yibo
2026-10-25  1:24   ` Alexei Starovoitov [this message]
2026-10-22  0:07 ` [PATCH bpf-next 3/3] selftests/bpf: say how to fix the missing LLVM skip for jited checks Wang Yibo
2026-10-22  0:28   ` bot+bpf-ci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMDIZDAS0MXY.3SBEZOHWHM0V8@gmail.com \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=szwyb123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox