From: "Alexei Starovoitov" <alexei.starovoitov@gmail.com>
To: "Kumar Kartikeya Dwivedi" <memxor@gmail.com>
Cc: "Emil Tsalapatis" <emil@etsalapatis.com>, <bpf@vger.kernel.org>,
<andrii@kernel.org>, <eddyz87@gmail.com>, <daniel@iogearbox.net>,
"Tejun Heo" <tj@kernel.org>
Subject: Re: [PATCH bpf 1/2] bpf: recover page faults across all arenas
Date: Tue, 03 Nov 2026 01:47:22 +0000 [thread overview]
Message-ID: <DML73TNAFORF.67E0ZRLWONC@gmail.com> (raw)
In-Reply-To: <CAP01T77fBRqfCM=VVjq0Vo8zFYzBLL9Adw5Wr8ar-fb862L1RA@mail.gmail.com>
On Mon, Nov 02, 2026 at 03:35 PM Kumar Kartikeya Dwivedi <memxor@gmail.com> wrote:
>> > - prog = bpf_prog_find_from_stack();
>>
>> This has to stay. If there are thousands arena. Above should still be a fast path.
>> Only for sched-ext arena access it should search link link.
>
> We cannot rely on this, there might be a different program in the call
> stack. That's why there is an equality check on the arena when
> actually reporting, to make sure it's going to the right program.
I meant it as a fast path, not as the only path.
the equality check is needed, of course.
A different prog on the stack will fail that check and
the handler will do latch search.
next prev parent reply other threads:[~2026-11-03 1:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 1:51 [PATCH bpf-next 0/2] bpf: expand BPF arena kernel fault handling Emil Tsalapatis
2026-10-28 1:51 ` [PATCH bpf 1/2] bpf: recover page faults across all arenas Emil Tsalapatis
2026-10-28 2:36 ` bot+bpf-ci
2026-11-02 22:58 ` Alexei Starovoitov
2026-11-02 23:35 ` Kumar Kartikeya Dwivedi
2026-11-03 1:47 ` Alexei Starovoitov [this message]
2026-10-28 1:51 ` [PATCH bpf 2/2] selftests/bpf: add arena fault recovery tests Emil Tsalapatis
2026-10-28 2:13 ` sashiko-bot
2026-11-02 22:59 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DML73TNAFORF.67E0ZRLWONC@gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=memxor@gmail.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox