From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2666C433FE for ; Tue, 22 Mar 2022 02:16:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235370AbiCVCRj (ORCPT ); Mon, 21 Mar 2022 22:17:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235395AbiCVCRg (ORCPT ); Mon, 21 Mar 2022 22:17:36 -0400 Received: from out1.migadu.com (out1.migadu.com [IPv6:2001:41d0:2:863f::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC4431FA74; Mon, 21 Mar 2022 19:15:08 -0700 (PDT) Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1647915306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jYNLCxTmIoThWrGCuegM5gDTHrucNh1xrWSH6I5PEO0=; b=fXdQwjSAoV9xZV35ZvSbWJs3jpn2qSq2PfgdJQcu2TasdcwY3RuP5CanKxtsNCrtRJAESD 49FfRjVPltdpY/yuBC6za22uugHxL5tCWHlWhKW/zWb3A0aW1oY6dLWeBcccVG4tCOoHpA uyV9baq9EFq+BQAAObUL1F3mmaP0X7I= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [PATCH] bpf: selftests: cleanup RLIMIT_MEMLOCK X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin In-Reply-To: Date: Mon, 21 Mar 2022 19:15:03 -0700 Cc: Yafang Shao , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin Lau , Song Liu , Yonghong Song , john fastabend , KP Singh , Networking , bpf Message-Id: References: To: Andrii Nakryiko X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org > On Mar 21, 2022, at 5:13 PM, Andrii Nakryiko w= rote: >=20 > =EF=BB=BFOn Sun, Mar 20, 2022 at 9:58 AM Roman Gushchin wrote: >>=20 >>=20 >>>> On Mar 19, 2022, at 11:08 PM, Yafang Shao wrote:= >>>=20 >>> =EF=BB=BFSince we have alread switched to memcg-based memory accouting a= nd control, >>> we don't need RLIMIT_MEMLOCK any more. >>>=20 >>> Signed-off-by: Yafang Shao >>> Cc: Roman Gushchin >>>=20 >>> --- >>> RLIMIT_MEMLOCK is still used in bpftool and libbpf, but it may be useful= >>> for backward compatibility, so I don't cleanup them. >>=20 >> Hi Yafang! >>=20 >> As I remember, we haven=E2=80=99t cleaned selftests up with the same logi= c: it=E2=80=99s nice to be able to run the same version of tests on older ke= rnels. >>=20 >=20 > It should be fine, at least for test_progs and test_progs-no_alu32. > Libbpf now does this automatically if running in "libbpf 1.0" mode. Didn=E2=80=99t know this, thanks! Do we link all tests with it? >=20 > Yafang, please make sure that all the test binaries you are cleaning > up have libbpf_set_strict_mode(LIBBPF_STRICT_ALL) (test_progs does > already). You might need to clean up some SEC() definitions, in case > we still missed some non-conforming ones, though. If so, no objections to the patch from my side. Thank you!=