From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D580DC433FE for ; Fri, 4 Dec 2020 09:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CC69227BF for ; Fri, 4 Dec 2020 09:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729765AbgLDJl7 (ORCPT ); Fri, 4 Dec 2020 04:41:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729673AbgLDJl6 (ORCPT ); Fri, 4 Dec 2020 04:41:58 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 731E6C061A51 for ; Fri, 4 Dec 2020 01:41:18 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id r3so4662803wrt.2 for ; Fri, 04 Dec 2020 01:41:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=eo6TBMS+qk+t9M6N3qC5XSs2V4IF7uYP9cX9A/8rdaQ=; b=sMR5PZlI4ZB+qaf6iZ55WyVSaZ0HlbSkRxQF7Yujg1nGd2BVJBKjTfcEZro4gdeTwV qkVVAs8qguQCB/IgBKa4q0l2uDo6u6Fd6Gt/ca/VrDrBBLqRIv267BrR19aOhBwPWQxW C7VGxCEiQCb9TizIm8ojjs03DpeftgzwoQaRh6ICl76aETNIoLBnfun0edwnaRZNmcYU pg9UjGTLitL8wN4Zzv0W8F+4U+EoH/5ZBkIoCmxyIXuBAEJmFow5UUunq9RTtyjqO8k5 C0jGc+ZQ/7EX/PzOyEl/P6mYbsueH6mDCQO8K+H1bYRxoHPNpeC8SVHMxLRNHz0VB2B+ OIzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=eo6TBMS+qk+t9M6N3qC5XSs2V4IF7uYP9cX9A/8rdaQ=; b=N+H9tUjDOYtuydcLqSXrnywnivbdyi28CwoR4MvO4f/xroYrfLwx/HmdkcfBtSU6kJ KJPDwxKkw9ssNpFYhoj5d52K7Wo5PtQptWnqxu69M8DOdJXuict6hiui2mq2oo9KqGm9 BZetv4wzadFobXNMbfAzX5Q5st4fMU9Ta96fx4M1istw3AHCgI/sf6XeR2ev+aY2u+0J 2j04d70+xD0ggxEvZvPhN5aGWwZj5RYY++/dWNzpO9qXY+yqkZsi4Z+OYYXa/JyrnBRU +3ubDVW4wLV1FlrMhI64Y1eiq9WtCrblUvV5jlXVl6u7GSeoSmrXOL+TTXlJeU9/Jdm6 XP2g== X-Gm-Message-State: AOAM532+J27izfuvotMoYCaGoS++fhbIjqJcDZjJe0vRsiX50PtSGrPy EahQw2xEMLGPadfeihLay7f5AUa3mVBgyA== X-Google-Smtp-Source: ABdhPJwxfLTMFNu80EYp5tbP2osGr/ykvfAJeQKYWvN9M7puBShi2QdMZtBlBhqcPGMu8lzhZGteKA== X-Received: by 2002:adf:8483:: with SMTP id 3mr3891625wrg.165.1607074876977; Fri, 04 Dec 2020 01:41:16 -0800 (PST) Received: from google.com (203.75.199.104.bc.googleusercontent.com. [104.199.75.203]) by smtp.gmail.com with ESMTPSA id l16sm2874013wrx.5.2020.12.04.01.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 01:41:16 -0800 (PST) Date: Fri, 4 Dec 2020 09:41:12 +0000 From: Brendan Jackman To: Andrii Nakryiko Cc: bpf , Alexei Starovoitov , Yonghong Song , Daniel Borkmann , KP Singh , Florent Revest , open list , Jann Horn Subject: Re: [PATCH bpf-next v3 12/14] bpf: Pull tools/build/feature biz into selftests Makefile Message-ID: References: <20201203160245.1014867-1-jackmanb@google.com> <20201203160245.1014867-13-jackmanb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Dec 03, 2020 at 01:01:27PM -0800, Andrii Nakryiko wrote: > On Thu, Dec 3, 2020 at 8:07 AM Brendan Jackman wrote: > > > > This is somewhat cargo-culted from the libbpf build. It will be used > > in a subsequent patch to query for Clang BPF atomics support. > > > > Change-Id: I9318a1702170eb752acced35acbb33f45126c44c > > Haven't seen this before. What's this Change-Id business? Argh, apologies. Looks like it's time for me to adopt a less error-prone workflow for sending patches. (This is noise from Gerrit, which we sometimes use for internal reviews) > > Signed-off-by: Brendan Jackman > > --- > > tools/testing/selftests/bpf/.gitignore | 1 + > > tools/testing/selftests/bpf/Makefile | 38 ++++++++++++++++++++++++++ > > 2 files changed, 39 insertions(+) > > All this just to detect the support for clang atomics?... Let's not > pull in the entire feature-detection framework unnecessarily, > selftests Makefile is complicated enough without that. Then the test build would break for people who haven't updated Clang. Is that acceptable? I'm aware of cases where you need to be on a pretty fresh Clang for tests to _pass_ so maybe it's fine.