Re: [PATCH V5] bpf, docs: Document BPF insn encoding in term of stored bytes

[David Vernet <void@manifault.com>]

On Tue, Feb 28, 2023 at 10:51:29AM +0100, Jose E. Marchesi wrote:
> 
> [Changes from V4:
> - s/regs:16/regs:8 in figure.]
> 
> [Changes from V3:
> - Back to src_reg and dst_reg, since they denote register numbers
>   as opposed to the values stored in these registers.]
> 
> [Changes from V2:
> - Use src and dst consistently in the document.
> - Use a more graphical depiction of the 128-bit instruction.
> - Remove `Where:' fragment.
> - Clarify that unused bits are reserved and shall be zeroed.]
> 
> [Changes from V1:
> - Use rst literal blocks for figures.
> - Avoid using | in the basic instruction/pseudo instruction figure.
> - Rebased to today's bpf-next master branch.]
> 
> This patch modifies instruction-set.rst so it documents the encoding
> of BPF instructions in terms of how the bytes are stored (be it in an
> ELF file or as bytes in a memory buffer to be loaded into the kernel
> or some other BPF consumer) as opposed to how the instruction looks
> like once loaded.
> 
> This is hopefully easier to understand by implementors looking to
> generate and/or consume bytes conforming BPF instructions.
> 
> The patch also clarifies that the unused bytes in a pseudo-instruction
> shall be cleared with zeros.
> 
> Signed-off-by: Jose E. Marchesi <jose.marchesi@oracle.com>

Acked-by: David Vernet <void@manifault.com>