From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86683C636CC for ; Wed, 15 Feb 2023 03:44:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229686AbjBODn7 (ORCPT ); Tue, 14 Feb 2023 22:43:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbjBODn6 (ORCPT ); Tue, 14 Feb 2023 22:43:58 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1787330184; Tue, 14 Feb 2023 19:43:57 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id d2so16965639pjd.5; Tue, 14 Feb 2023 19:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QXx6lEwD2TEgOQrVayIfHTVdxpHuO1zPkPYf3xv3xtw=; b=Q1rTsXnoB3obtyVtX4GfqR/zWDu/Df5wVPlIDHjKg46vnqPGJc0+28fiedhAQFF6KC FNX/m0sbtLZG1vkxuGXh7IvbQ3mmXfjiQ7kmlm6bktfbGYnSLXIfJaq9vMT04jl3A3Ta D1//u5n2di7srwVBCwF7mq5DdNVdUJ16MDpEbe24w+M4Q9E9MfFCAN7LPKI7IVH15o87 pvZSF4GoI6LLquasg7RzvIkioVRMhEydDKRH/ZQVX53h0wlm9B7KJqIFBa8ereiFHIvD 23hUZ8ZoBFmkMDASqdKU5WY0mtIbZCs+d+/xPpAsU2UyU+S7rktpf/Vth6IDo7LqW+Ha aPXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QXx6lEwD2TEgOQrVayIfHTVdxpHuO1zPkPYf3xv3xtw=; b=fGdH2n6V6rx7N9idlpXG1jmJvO2C35+Ca1FSneHqRYxoHaNAgmivitvTpSalPGyFVz W+owGlvh1SbPYvvObkZc/wWT/VlyxnozEfKHj5WGCb6lSZBPFrMvX54cmMgc0Bb0QUXS ipJhajrWRzbgfenmGI9Q2j0mDg6fxPzp/Z5HZ/3vIzg9OtKWjyn2plzyB6zKEkKKjXyf bPBJC397FnluTqfKJ/4eoCWqbtDWDvpQf8TO88pHM2CRywSouk3p3351xjThMI5BccFT xgdLDWbPxd2ob2i9E3gq2XQH96pVpEuI5zr0uP5IZqN/wow2a2bxzbH5T4w85XqJ+yy+ u2+A== X-Gm-Message-State: AO0yUKVCideQyyU2Tpw9nF5LIWMzBgDvw7I3DVQY5/8ZQI+k0gMKnqqK hh+E6hDYfYk3GeJtAlFvwnG9MdvMA8UkoQ== X-Google-Smtp-Source: AK7set+aDPeR/pNnHNeLF5I8RiB6SfJjYY8z+6cPCM7Ze4rq8zHobFTUM5eMqWl9QQveSfcVMj4ZQA== X-Received: by 2002:a17:902:e80b:b0:196:725c:6ea with SMTP id u11-20020a170902e80b00b00196725c06eamr1045418plg.19.1676432636542; Tue, 14 Feb 2023 19:43:56 -0800 (PST) Received: from Laptop-X1 ([43.228.180.230]) by smtp.gmail.com with ESMTPSA id e18-20020a170902ed9200b0019904abc93dsm10948008plj.250.2023.02.14.19.43.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 19:43:54 -0800 (PST) Date: Wed, 15 Feb 2023 11:43:46 +0800 From: Hangbin Liu To: Martin KaFai Lau Cc: Matthieu Baerts , netdev@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , bpf@vger.kernel.org, Jakub Kicinski , "David S . Miller" , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Felix Maurer , Davide Caratti Subject: Re: [PATCH bpf] selftests/bpf: enable mptcp before testing Message-ID: References: <20230210093205.1378597-1-liuhangbin@gmail.com> <6f0a72ee-ec30-8c97-0285-6c53db3d4477@tessares.net> <19a6a29d-85f3-b8d7-c9d9-3c97a625bd13@tessares.net> <78481d57-4710-aa06-0ff7-fee075458aae@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78481d57-4710-aa06-0ff7-fee075458aae@linux.dev> Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Feb 14, 2023 at 11:22:58AM -0800, Martin KaFai Lau wrote: > On 2/13/23 7:11 PM, Hangbin Liu wrote: > > On Mon, Feb 13, 2023 at 05:28:19PM +0100, Matthieu Baerts wrote: > > > But again, I'm not totally against that, I'm just saying that if these > > > tests are executed in dedicated netns, this modification is not needed > > > when using a vanilla kernel ;-) > > > > > > Except if I misunderstood and these tests are not executed in dedicated > > > netns? > > > > I tried on my test machine, it looks the test is executed in init netns. > > The new test is needed to run under its own netns whenever possible. The > existing mptcp test should be changed to run in its own netns also. Then > changing any pernet sysctl (eg. mptcp.enabled) is a less concern to other > tests. You can take a look at how other tests doing it (eg. decap_sanity.c). Thanks for the reference. I will update the patch to make mptcp run in it's own netns. Hangbin