From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Olsa <olsajiri@gmail.com>
Cc: Sumanth Korikkar <sumanthk@linux.ibm.com>,
bpf@vger.kernel.org, gor@linux.ibm.com, hca@linux.ibm.com,
iii@linux.ibm.com, linux-kernel@vger.kernel.org,
linux-tip-commits@vger.kernel.org, namhyung@kernel.org,
svens@linux.ibm.com, tip-bot2@linutronix.de,
tmricht@linux.ibm.com, x86@kernel.org
Subject: Re: [PATCH] bpf: fix sample_flags for bpf_perf_event_output
Date: Fri, 7 Oct 2022 17:18:48 +0200 [thread overview]
Message-ID: <Y0BDWK7cl83Fkwqz@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <Yz/1QNGfO39Y7dOJ@krava>
On Fri, Oct 07, 2022 at 11:45:36AM +0200, Jiri Olsa wrote:
> On Fri, Oct 07, 2022 at 10:13:27AM +0200, Sumanth Korikkar wrote:
> > * Raw data is also filled by bpf_perf_event_output.
> > * Add sample_flags to indicate raw data.
> > * This eliminates the segfaults as shown below:
> > Run ./samples/bpf/trace_output
> > BUG pid 9 cookie 1001000000004 sized 4
> > BUG pid 9 cookie 1001000000004 sized 4
> > BUG pid 9 cookie 1001000000004 sized 4
> > Segmentation fault (core dumped)
> >
> > Fixes: 838d9bb62d13 ("perf: Use sample_flags for raw_data")
> > Acked-by: Namhyung Kim <namhyung@kernel.org>
> > Signed-off-by: Sumanth Korikkar <sumanthk@linux.ibm.com>
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> Peter,
> I think this should go through your tree again?
> bpf-next/master does not have sample_flags merged yet
Yep can do. I'll line it up in perf/urgent (Ingo just send out
perf/core).
next prev parent reply other threads:[~2022-10-07 15:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166434824149.401.4361243714612738808.tip-bot2@tip-bot2>
2022-10-06 16:00 ` [PATCH] Re: [tip: perf/core] perf: Use sample_flags for raw_data Sumanth Korikkar
2022-10-06 17:12 ` Namhyung Kim
2022-10-06 18:58 ` Jiri Olsa
2022-10-07 8:13 ` [PATCH] bpf: fix sample_flags for bpf_perf_event_output Sumanth Korikkar
2022-10-07 9:45 ` Jiri Olsa
2022-10-07 15:18 ` Peter Zijlstra [this message]
2022-10-19 4:57 ` Alexei Starovoitov
2022-10-21 1:36 ` Alexei Starovoitov
2022-10-23 1:16 ` bpf+perf is still broken. Was: " Alexei Starovoitov
2022-10-23 16:55 ` Linus Torvalds
2022-10-23 17:19 ` Linus Torvalds
2022-10-23 17:28 ` Alexei Starovoitov
2022-10-17 19:27 ` SeongJae Park
2022-10-17 22:52 ` Namhyung Kim
2022-10-17 23:35 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0BDWK7cl83Fkwqz@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bpf@vger.kernel.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=olsajiri@gmail.com \
--cc=sumanthk@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=tip-bot2@linutronix.de \
--cc=tmricht@linux.ibm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox