From: David Vernet <void@manifault.com>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: bpf@vger.kernel.org, 'Alexei Starovoitov ' <ast@kernel.org>,
'Andrii Nakryiko ' <andrii@kernel.org>,
'Daniel Borkmann ' <daniel@iogearbox.net>,
kernel-team@fb.com, Manu Bretelle <chantra@meta.com>
Subject: Re: [PATCH bpf-next] selftests/bpf: s/iptables/iptables-legacy/ in the bpf_nf and xdp_synproxy test
Date: Wed, 12 Oct 2022 17:18:01 -0500 [thread overview]
Message-ID: <Y0c9GeIeF0+AErO2@maniforge.dhcp.thefacebook.com> (raw)
In-Reply-To: <20221012221235.3529719-1-martin.lau@linux.dev>
On Wed, Oct 12, 2022 at 03:12:35PM -0700, Martin KaFai Lau wrote:
> From: Martin KaFai Lau <martin.lau@kernel.org>
>
> The recent vm image in CI has reported error in selftests that use
> the iptables command. Manu Bretelle has pointed out the difference
> in the recent vm image that the iptables is sym-linked to the iptables-nft.
> With this knowledge, I can also reproduce the CI error by manually running
> with the 'iptables-nft'.
>
> This patch is to replace the iptables command with iptables-legacy
> to unblock the CI tests.
>
> Cc: Manu Bretelle <chantra@meta.com>
> Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
LGTM, thanks for fixing this.
Acked-by: David Vernet <void@manifault.com>
next prev parent reply other threads:[~2022-10-12 22:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 22:12 [PATCH bpf-next] selftests/bpf: s/iptables/iptables-legacy/ in the bpf_nf and xdp_synproxy test Martin KaFai Lau
2022-10-12 22:18 ` David Vernet [this message]
2022-10-13 15:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0c9GeIeF0+AErO2@maniforge.dhcp.thefacebook.com \
--to=void@manifault.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chantra@meta.com \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox