From: Jiri Olsa <olsajiri@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>, Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Olsa <olsajiri@gmail.com>,
Martin KaFai Lau <martin.lau@kernel.org>,
bpf@vger.kernel.org,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: WARN: multiple IDs found for 'nf_conn': 92168, 117897 - using 92168
Date: Thu, 13 Oct 2022 23:55:41 +0200 [thread overview]
Message-ID: <Y0iJXajhKPlqjOIO@krava> (raw)
In-Reply-To: <20221013080517.621b8d83@kernel.org>
On Thu, Oct 13, 2022 at 08:05:17AM -0700, Jakub Kicinski wrote:
> On Wed, 5 Oct 2022 22:07:57 +0200 Jiri Olsa wrote:
> > > Yeah, it's there on linux-next, too.
> > >
> > > Let me grab a fresh VM and try there. Maybe it's my system. Somehow.
> >
> > ok, I will look around what's the way to install that centos 8 thing
>
> Any luck?
yea, sorry for delay, I reproduced that.. first objtool warnings ;-)
[jolsa@centos8 linux-next]$ make
UPD include/generated/compile.h
CALL scripts/checksyscalls.sh
DESCEND objtool
DESCEND bpf/resolve_btfids
CC init/version.o
AR init/built-in.a
AR built-in.a
AR vmlinux.a
LD vmlinux.o
vmlinux.o: warning: objtool: relocate_restore_code+0x3c: relocation to !ENDBR: next_arg+0x8
vmlinux.o: warning: objtool: ___ksymtab+bpf_dispatcher_xdp_func+0x0: data relocation to !ENDBR: bpf_dispatcher_xdp_func+0x0
vmlinux.o: warning: objtool: bpf_dispatcher_xdp+0x20: data relocation to !ENDBR: bpf_dispatcher_xdp_func+0x0
...
Peter,
as for objtool warnings, looks like with gcc we'll get
endbr64 instruction generated after nops
with centos gcc 8.5:
ffffffff818d2e20 <bpf_dispatcher_xdp_func>:
ffffffff818d2e20: 90 nop
ffffffff818d2e21: 90 nop
ffffffff818d2e22: 90 nop
ffffffff818d2e23: 90 nop
ffffffff818d2e24: 90 nop
ffffffff818d2e25: f3 0f 1e fa endbr64
ffffffff818d2e29: e9 92 eb 52 00 jmpq ffffffff81e019c0 <__x86_indirect_thunk_rdx>
ffffffff818d2e2e: 66 90 xchg %ax,%ax
while latest gcc 12 will put it after:
ffffffff82736900 <bpf_dispatcher_xdp_func>:
ffffffff82736900: f3 0f 1e fa endbr64
ffffffff82736904: 90 nop
ffffffff82736905: 90 nop
ffffffff82736906: 90 nop
ffffffff82736907: 90 nop
ffffffff82736908: 90 nop
ffffffff82736909: 41 54 push %r12
ffffffff8273690b: 49 89 f4 mov %rsi,%r12
ffffffff8273690e: 55 push %rbp
ffffffff8273690f: 48 89 fd mov %rdi,%rbp
ffffffff82736912: 53 push %rbx
ffffffff82736913: 48 89 d3 mov %rdx,%rbx
ffffffff82736916: e8 65 f6 cf fe call ffffffff81435f80 <__sanitizer_cov_trace_pc>
ffffffff8273691b: 4c 89 e6 mov %r12,%rsi
ffffffff8273691e: 48 89 ef mov %rbp,%rdi
ffffffff82736921: 48 89 d8 mov %rbx,%rax
ffffffff82736924: 5b pop %rbx
ffffffff82736925: 5d pop %rbp
ffffffff82736926: 41 5c pop %r12
ffffffff82736928: e9 b3 b6 8c 00 jmp ffffffff83001fe0 <__x86_indirect_thunk_array>
any idea where's the problem? bad backport? ;-)
in any case (unrelated), I'll check the bpf dispatcher code,
I'm not sure the nop update code is aware of the endbr64 instruction
jirka
next prev parent reply other threads:[~2022-10-13 21:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 2:05 objtool: bpf_dispatcher_xdp+0xa0: data relocation to !ENDBR: Jakub Kicinski
2022-10-04 4:49 ` WARN: multiple IDs found for 'nf_conn': 92168, 117897 - using 92168 Jakub Kicinski
2022-10-04 6:42 ` Jiri Olsa
2022-10-04 14:25 ` Jakub Kicinski
2022-10-05 9:45 ` Jiri Olsa
2022-10-05 15:44 ` Jakub Kicinski
2022-10-05 16:18 ` Jakub Kicinski
2022-10-05 20:07 ` Jiri Olsa
2022-10-13 15:05 ` Jakub Kicinski
2022-10-13 21:55 ` Jiri Olsa [this message]
2022-10-13 22:12 ` Jiri Olsa
2022-10-13 22:24 ` Andrii Nakryiko
2022-10-14 6:47 ` Jiri Olsa
2022-10-14 17:17 ` Alan Maguire
2022-10-21 18:18 ` Andrii Nakryiko
2022-10-21 21:34 ` Jiri Olsa
2022-10-22 5:36 ` Jakub Kicinski
2022-10-23 1:18 ` Alexei Starovoitov
2022-10-24 18:21 ` Jakub Kicinski
2022-10-04 14:46 ` Daniel Xu
2022-10-04 15:34 ` Jakub Kicinski
2022-10-18 15:11 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0iJXajhKPlqjOIO@krava \
--to=olsajiri@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=martin.lau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).