From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E35B1C433FE for ; Sat, 22 Oct 2022 01:05:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229909AbiJVBFS (ORCPT ); Fri, 21 Oct 2022 21:05:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbiJVBFR (ORCPT ); Fri, 21 Oct 2022 21:05:17 -0400 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE025DBBC0 for ; Fri, 21 Oct 2022 18:05:15 -0700 (PDT) Received: by mail-pf1-x429.google.com with SMTP id i3so4129597pfk.9 for ; Fri, 21 Oct 2022 18:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=w+Z+m5UuoZHqqDXA1rEmzYhm7dcY5Bs+/QhLDNEhRA0=; b=Pv2joy2iRYtTBgYdIUiLrZJD6ZX7HWAkDhmmll9hggwP7Y7vf/FgVwFQeoEWCIjeHJ H0ho2PI0/XT0AZYSwy2wq9Y/7wQOFPJeuanx0l4Ylf2xHjKyxKcYpJkZ96P1paJHmHrE GV8aNSp5yslQhDJMKjnNfl9yDYfLyzwKEYrCXbFOuE6lE/Qq7+FlEAB90H0KRbQWqS8U vA7zXo59QMyF6ousU0SfgsiVnfUAQT+g4NoCgiv7zAhudZr1kqVywtCMd1036xHTczwT qYBg27pMf6qEC6GV0zUHy8jPbrkAN0hJc915MNbPn3aQS1KlGYxN5py+k6W5tb1qUlIh ALRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w+Z+m5UuoZHqqDXA1rEmzYhm7dcY5Bs+/QhLDNEhRA0=; b=PflzcPsbz9TbyRnFUKlLXCxXr42ZPjYv8WX5nfUxDP/VNvUbSc4jpFHA+k5DWZ4khn O8qf4krGJ11eAPmHpe1B1vpwWTe+nXE+iRKPthu58TbyKJUYIykOP5o7d9Kov7NGKwz+ cuZ8yW2SfLNlfN+Gzku1U5ytSBdFEaj22DKTIZnw3XQt2EUqdPXzPvo1Q/T+rUua7D4e snN6eYLIKwcVYuqZC1kyM25aUONHWahAimRE1ZjMa9BWB9cDSl4HgjIov4KQi1zV9q0c ClZ6Z6Zl7jShBPdMTVWY+ML31RcySyS8ng8nw3ghs7qGRkJLtL3+ieXF2T7ZlYTSPyjK Vuqw== X-Gm-Message-State: ACrzQf0xhI4CHT56ZBgoP31MSZiHPZmGgu9BdVGrH+RJI0W8267yYnkL jMh2ph4/nMfNGu9D9CW7qhRwEBUBGvS42A== X-Google-Smtp-Source: AMsMyM7qHjOqP1zRXC9YSmfaO4u3sDgHDwfshDpcpr6SdGYKqCn4QNl5VG8gY2B8F1wErvNYSZH+Fg== X-Received: by 2002:a63:4a4b:0:b0:439:837:cc8d with SMTP id j11-20020a634a4b000000b004390837cc8dmr18591550pgl.199.1666400714831; Fri, 21 Oct 2022 18:05:14 -0700 (PDT) Received: from localhost (2603-800c-1a02-1bae-e24f-43ff-fee6-449f.res6.spectrum.com. [2603:800c:1a02:1bae:e24f:43ff:fee6:449f]) by smtp.gmail.com with ESMTPSA id 186-20020a6215c3000000b005626ef1a48bsm15638107pfv.197.2022.10.21.18.05.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 18:05:14 -0700 (PDT) Sender: Tejun Heo Date: Fri, 21 Oct 2022 15:05:12 -1000 From: Tejun Heo To: Yonghong Song Cc: Andrii Nakryiko , Yonghong Song , bpf@vger.kernel.org, Alexei Starovoitov , Andrii Nakryiko , Daniel Borkmann , kernel-team@fb.com, KP Singh , Martin KaFai Lau Subject: Re: [PATCH bpf-next v2 3/6] libbpf: Support new cgroup local storage Message-ID: References: <20221020221255.3553649-1-yhs@fb.com> <20221020221311.3554642-1-yhs@fb.com> <966cb96e-e0a0-aec5-1cce-a4c9fbc0ca5f@meta.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <966cb96e-e0a0-aec5-1cce-a4c9fbc0ca5f@meta.com> Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hello, On Fri, Oct 21, 2022 at 05:32:58PM -0700, Yonghong Song wrote: > > LGTM, but I do think that BPF_MAP_TYPE_CG_STORAGE and "cg_storage" is > > easier to read and talk about. But that's minor. > > I searched kernel/cgroup/* and kernel/bpf/cgroup.c and > include/linux/cgroup*.h. The 'cgrp' for abbreviation of 'cgroup' is much > more than > 'cg' for 'cgroup' unless 'cg' appears in like 'memcg' or 'rdmacg'. So I > would just use 'cgrp' for now. Yeah, cgrp is more consistent for prefixes and variable names. cg is usually used as a part of an abbreviated word - memcg, blkcg, cgid and so on. Thanks. -- tejun