Re: [PATCH bpf-next v8 1/1] doc: DEVMAPs and XDP_REDIRECT

[Bagas Sanjaya <bagasdotme@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

On Thu, Nov 10, 2022 at 11:08:18AM -0500, mtahhan@redhat.com wrote:
> From: Maryam Tahhan <mtahhan@redhat.com>
> 
> Add documentation for BPF_MAP_TYPE_DEVMAP and
> BPF_MAP_TYPE_DEVMAP_HASH including kernel version
> introduced, usage and examples.
> 
> Add documentation that describes XDP_REDIRECT.

Shouldn't two documentations be separated into its own patch (thus
creating 2-patch series)?

 
> +XDP_REDIRECT works with the following map types:
> +
><snipped>...
> +Silent packet drops for ``XDP_REDIRECT`` can be debugged using:
> +
> +- bpf_trace
> +- perf_record

XDP_REDIRECT is inline-quoted here, but plain on other places. I would
like to keep that above plain instead.

What about below instead?

```
Silent packet drops for ``XDP_REDIRECT`` can be debugged using either
bpf_trace tool or ``perf record`` command.
```

Otherwise LGTM.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]