From: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@industrialdiscipline.com>
To: Yonghong Song <yhs@meta.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, quentin@isovalent.com, martin.lau@linux.dev,
song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
jolsa@kernel.org
Subject: Re: [PATCH bpf-next v2 0/5] clean-up bpftool from legacy support
Date: Sun, 13 Nov 2022 08:43:34 +0000 [thread overview]
Message-ID: <Y3CuJ5GtVg+fEH+z@system76-pc.localdomain> (raw)
In-Reply-To: <8f340958-71da-508c-bf57-73daa0fd22cc@meta.com>
On 11/09/ , Yonghong Song wrote:
>
>
> On 11/8/22 11:44 PM, Sahid Orentino Ferdjaoui wrote:
> > As part of commit 93b8952d223a ("libbpf: deprecate legacy BPF map
> > definitions") and commit bd054102a8c7 ("libbpf: enforce strict libbpf
> > 1.0 behaviors") The --legacy option is not relevant anymore. #1 is
> > removing it. #4 is cleaning the code from using libbpf_get_error().
> >
> > About patches #2 and #3 They are changes discovered while working on
> > this series (credits to Quentin Monnet). #2 is cleaning-up usage of an
> > unnecessary PTR_ERR(NULL), finally #3 is fixing an invalid value
> > passed to strerror().
> >
> > v1 -> v2:
> > - Addressed review comments from Yonghong Song on patch #4
> > - Added a patch #5 that removes unwanted function noticed by
> > Yonghong Song
> >
> > Sahid Orentino Ferdjaoui (5):
> > bpftool: remove support of --legacy option for bpftool
> > bpftool: replace return value PTR_ERR(NULL) with 0
> > bpftool: fix error message when function can't register struct_ops
> > bpftool: clean-up usage of libbpf_get_error()
> > bpftool: remove function free_btf_vmlinux()
> >
> > .../bpftool/Documentation/common_options.rst | 9 --------
> > .../bpftool/Documentation/substitutions.rst | 2 +-
> > tools/bpf/bpftool/bash-completion/bpftool | 2 +-
> > tools/bpf/bpftool/btf.c | 17 ++++++--------
> > tools/bpf/bpftool/btf_dumper.c | 2 +-
> > tools/bpf/bpftool/gen.c | 11 ++++------
> > tools/bpf/bpftool/iter.c | 6 ++---
> > tools/bpf/bpftool/main.c | 22 +++----------------
> > tools/bpf/bpftool/main.h | 3 +--
> > tools/bpf/bpftool/map.c | 20 ++++++-----------
> > tools/bpf/bpftool/prog.c | 15 +++++--------
> > tools/bpf/bpftool/struct_ops.c | 22 ++++++++-----------
> > .../selftests/bpf/test_bpftool_synctypes.py | 6 ++---
> > 13 files changed, 44 insertions(+), 93 deletions(-)
> >
> > --
> > 2.34.1
> >
>
> You can carry the 'Ack' if no significant change for
> each patch.
Thanks a lot for this advice. I will use this in my v3 when addressing
Andrii comments.
> Ack for the whole series.
>
> Acked-by: Yonghong Song <yhs@fb.com>
prev parent reply other threads:[~2022-11-13 8:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 7:44 [PATCH bpf-next v2 0/5] clean-up bpftool from legacy support Sahid Orentino Ferdjaoui
2022-11-09 7:45 ` [PATCH bpf-next v2 1/5] bpftool: remove support of --legacy option for bpftool Sahid Orentino Ferdjaoui
2022-11-09 7:45 ` [PATCH bpf-next v2 2/5] bpftool: replace return value PTR_ERR(NULL) with 0 Sahid Orentino Ferdjaoui
2022-11-09 23:58 ` Andrii Nakryiko
2022-11-09 15:54 ` [PATCH bpf-next v2 0/5] clean-up bpftool from legacy support Yonghong Song
2022-11-13 8:43 ` Sahid Orentino Ferdjaoui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3CuJ5GtVg+fEH+z@system76-pc.localdomain \
--to=sahid.ferdjaoui@industrialdiscipline.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=quentin@isovalent.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
--cc=yhs@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox