From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95716C54EBD for ; Mon, 9 Jan 2023 17:39:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237191AbjAIRj2 (ORCPT ); Mon, 9 Jan 2023 12:39:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237011AbjAIRj1 (ORCPT ); Mon, 9 Jan 2023 12:39:27 -0500 Received: from mail-pg1-x549.google.com (mail-pg1-x549.google.com [IPv6:2607:f8b0:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81B0A2658 for ; Mon, 9 Jan 2023 09:39:26 -0800 (PST) Received: by mail-pg1-x549.google.com with SMTP id y37-20020a634b25000000b004b1d90ea947so1869785pga.15 for ; Mon, 09 Jan 2023 09:39:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=6EYMc5+vcvT6f31eLJLkK3p4u36cmy2i+T+Mh/4Q6NA=; b=FLs67g0QQc461pVpmVYzv4JE42HcNJbYVaVQb86HYVjfvccG7Wve5dzAONsJVLjl3l Kd3Bh3ROGfbudVrMmXU/eCnEBE/znoDln/DcgPLDeNgaUBkIUZ2UaJIOS8wMi0LSERgh wgcWtKCgu98ayOkdDY+ifxqZaqtzjM77Ap2i0oWMKI3/QDdgQxt/4YeSOMnUXBhWwboY lDBBvTaUxZNKyxLnC59v7GRd8us3KBx7ycMpLaVTANgMMVPtWo7T2xttqbrm6jvXxc61 8No1JfurnmCn4sAx7utqc+O0kjvC4lQU7OM0FpAApLY6DTU0t6x3ImBrnGVUo1N/07Ea 1GFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6EYMc5+vcvT6f31eLJLkK3p4u36cmy2i+T+Mh/4Q6NA=; b=glFPlmVKmFlr29+gsjBGwkjo/1cl9WvEpBZ969fSU48725ChogofO4MTo8vKtch9/v 92DCkPWN3MiQ4ZfUMwZ9bz8Czeoek16npBgt18THcGlkBa5+iZAhusA7XFo/uPahYHc4 Jpm93QrR+YQ9rhO3L3WXMyCSJIYx5IQ+9/3BRjX/bRnqXt5cp7XTv9pfyJHSuPheZgZa hSRJrEaidNZuaoLLgSJH9TWwsZ+Ug57mKqGUqG704M3Kna62jN2IsFOFZRIQd8SW3hgz bZPTubUX9q/Ah/UhYdFGMbz/F0EKInWKrbs/XsiaDPjm/bXHfZOUQq/vMKXMjeb8xcao dy2Q== X-Gm-Message-State: AFqh2krwjMp+mnLvWiI3dsNFH7kgKBlcwn51yDVB7Wnc/R9JspRw1TGK MLp79bm7t/7h3IgbM6pkHJ5XsMQ= X-Google-Smtp-Source: AMrXdXtvgn68FFnPUvQB/BnPtGld7g/pBzpiV+iqx7hVRMVQJmOFIdrSn3NeWo6eBus19cbmn3qcZTA= X-Received: from sdf.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5935]) (user=sdf job=sendgmr) by 2002:a17:903:451:b0:192:821b:dbda with SMTP id iw17-20020a170903045100b00192821bdbdamr3361160plb.58.1673285965987; Mon, 09 Jan 2023 09:39:25 -0800 (PST) Date: Mon, 9 Jan 2023 09:39:24 -0800 In-Reply-To: <20230108151258.96570-1-haiyue.wang@intel.com> Mime-Version: 1.0 References: <20230108151258.96570-1-haiyue.wang@intel.com> Message-ID: Subject: Re: [PATCH bpf-next v1] bpf: Remove the unnecessary insn buffer comparison From: sdf@google.com To: Haiyue Wang Cc: bpf@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Hao Luo , Jiri Olsa , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 01/08, Haiyue Wang wrote: > The variable 'insn' is initialized to 'insn_buf' without being changed, > only some helper macros are defined, so the insn buffer comparison is > unnecessary, just remove it. > Signed-off-by: Haiyue Wang Acked-by: Stanislav Fomichev Looks like these should have been removed as part of commit 2377b81de527 ("bpf: split shared bpf_tcp_sock and bpf_sock_ops implementation"). > --- > net/core/filter.c | 6 ------ > 1 file changed, 6 deletions(-) > diff --git a/net/core/filter.c b/net/core/filter.c > index ab811293ae5d..d9befa6ba04e 100644 > --- a/net/core/filter.c > +++ b/net/core/filter.c > @@ -6847,9 +6847,6 @@ u32 bpf_tcp_sock_convert_ctx_access(enum > bpf_access_type type, > FIELD)); \ > } while (0) > - if (insn > insn_buf) > - return insn - insn_buf; > - > switch (si->off) { > case offsetof(struct bpf_tcp_sock, rtt_min): > BUILD_BUG_ON(sizeof_field(struct tcp_sock, rtt_min) != > @@ -10147,9 +10144,6 @@ static u32 sock_ops_convert_ctx_access(enum > bpf_access_type type, > SOCK_OPS_GET_FIELD(BPF_FIELD, OBJ_FIELD, OBJ); \ > } while (0) > - if (insn > insn_buf) > - return insn - insn_buf; > - > switch (si->off) { > case offsetof(struct bpf_sock_ops, op): > *insn++ = BPF_LDX_MEM(BPF_FIELD_SIZEOF(struct bpf_sock_ops_kern, > -- > 2.39.0