From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3E34C38142 for ; Fri, 27 Jan 2023 14:11:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233361AbjA0OLB (ORCPT ); Fri, 27 Jan 2023 09:11:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231981AbjA0OK7 (ORCPT ); Fri, 27 Jan 2023 09:10:59 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9864F7E6F4 for ; Fri, 27 Jan 2023 06:10:42 -0800 (PST) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id EA28F3FFF7 for ; Fri, 27 Jan 2023 14:10:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1674828640; bh=oZN9ZgvVoZFD5cH0pJuh6IBZpyTqF0BSG7O/j2ykq4o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=gZiF6VsDymOpJpf0NsFNtmxeqUQKVBBckXeKexMbcluiotpMSzO6+CPTJg8hsAXEL KTraoC4x0RiOQPY81ouK2XG9EDMnXU5lsgVtlTv8iQhb0vbt3y64KD1gAG+m2uPAzR q/OQih1/6PQdxMjwEwB5vCHVJVdtssQ0J/DpBR2oCGeIs64QUhUCezIAsytGACpWSW ClDtY5NvsGzU2+VviTLL9EouagSAFaXRpen9HTl/yMe7u54q1QYfePzzxPRt8Uvu51 nMIninLQ9bfHsjSHMsTGzxsJX02Rz3e8DksaMCrAVifXDTriycoIZ6YkYJ3xt1X1M6 1JYsNRJk6uUCA== Received: by mail-wm1-f71.google.com with SMTP id l8-20020a05600c1d0800b003dc25f6bb5dso2787689wms.0 for ; Fri, 27 Jan 2023 06:10:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oZN9ZgvVoZFD5cH0pJuh6IBZpyTqF0BSG7O/j2ykq4o=; b=EK5+HR9CjlSmw2LgaSdRwF0tRyK7qVc1v3RzTKBJnhD3sevSjE2+yTzGxxc6DPaXup e9U86fdt1oCmwzxILR1BVUQ3au6fy1nybf8yG3MbjApxd5oZ2RH+gmcy+1XFLknvI3J4 ux+Zk/BhyWWlHwgAF1/XKdrtKWFNKMaz5MnrIjCUqxjxcg3z5/1lRyR6umFylHywSCs1 gbw54eg0xga6lZ/30nG9KJGjzI+fB5jnBq0ElXVerTFUgl4eodrG0SQMn+R8Ige5ELxo Mfws0LLRdBx5E4GbCWDw6s9eVDMnz/eGoCUi95cIARp0u4fa159GJTzn6V9UB1PHHM7k zv+A== X-Gm-Message-State: AFqh2krq3L0bVWLcOJ0RIsjc4WxYFmHHywqX5FDRgHyhMc0zLAi5KTMT UIqDQgMTGvlP1jKQdJU6DZPAEUIuOpniPKnRgpa28vNNKSSy8opPYg8o6yDN6m/nV9Nw5M6z0nw 6wBRPE3EKdprIenqwbb0gbR6msa5c2g== X-Received: by 2002:a5d:6e08:0:b0:2be:493d:1384 with SMTP id h8-20020a5d6e08000000b002be493d1384mr24246107wrz.22.1674828637787; Fri, 27 Jan 2023 06:10:37 -0800 (PST) X-Google-Smtp-Source: AMrXdXsXH+cOMzFUup27auMjUGxsJO9RSPYKSE+c7FGLX/KkpEARW9yOBWrq17aboos/PD+urHQSJA== X-Received: by 2002:a5d:6e08:0:b0:2be:493d:1384 with SMTP id h8-20020a5d6e08000000b002be493d1384mr24246095wrz.22.1674828637612; Fri, 27 Jan 2023 06:10:37 -0800 (PST) Received: from qwirkle ([81.2.157.149]) by smtp.gmail.com with ESMTPSA id a4-20020adffb84000000b002bc7f64efa3sm3999120wrr.29.2023.01.27.06.10.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Jan 2023 06:10:37 -0800 (PST) Date: Fri, 27 Jan 2023 14:10:35 +0000 From: Andrei Gherzan To: Jakub Kicinski Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Shuah Khan , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Hangbin Liu Subject: Re: [PATCH v2 1/2] selftests: net: Fix missing nat6to4.o when running udpgro_frglist.sh Message-ID: References: <20230125211350.113855-1-andrei.gherzan@canonical.com> <20230125230843.6ea157b1@kernel.org> <20230126153621.7503a73e@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230126153621.7503a73e@kernel.org> Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 23/01/26 03:36PM, Jakub Kicinski wrote: > On Thu, 26 Jan 2023 10:01:44 +0000 Andrei Gherzan wrote: > > On 23/01/25 11:08PM, Jakub Kicinski wrote: > > > On Wed, 25 Jan 2023 21:13:49 +0000 Andrei Gherzan wrote: > > > > The udpgro_frglist.sh uses nat6to4.o which is tested for existence in > > > > bpf/nat6to4.o (relative to the script). This is where the object is > > > > compiled. Even so, the script attempts to use it as part of tc with a > > > > different path (../bpf/nat6to4.o). As a consequence, this fails the script: > > > > > > Is this a recent regression? Can you add a Fixes tag? > > > > This issue seems to be included from the beginning (edae34a3ed92). I can't say > > why this was not seen before upstream but on our side, this test was disabled > > internally due to lack of CC support in BPF programs. This was fixed in the > > meanwhile in 837a3d66d698 (selftests: net: Add cross-compilation support for > > BPF programs) and we found this issue while trying to reenable the test. > > > > So if you think that is reasonable, I could add a Fixes tag for the initial > > script commit edae34a3ed92 (selftests net: add UDP GRO fraglist + bpf > > self-tests) and push a v3. > > We have queued commit 3c107f36db06 ("selftests/net: mv bpf/nat6to4.c > to net folder") in net-next, I think that should fix it, too? That would fix it indeed. Thanks for the pointer. > > > > What tree did you base this patch on? Doesn't seem to apply > > > > The patches were done on top of > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git, the master > > branch - 948ef7bb70c4 (Merge tag 'modules-6.2-rc6' of > > git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux). There is another > > merge that happened in the meanwhile but the rebase works without issues. I can > > send a rebased v3 if needed. > > Could you try linux-next or net-next ? I have sent a v3 rebased on linux-next, split out the remaining changes and added a commit to fix some shellcheck warnings/errors. -- Andrei Gherzan