From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net,
kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net,
song@kernel.org, toke@redhat.com
Subject: Re: [PATCH v3 bpf-next] cpumap: bulk skb using netif_receive_skb_list
Date: Tue, 20 Apr 2021 19:09:38 +0200 [thread overview]
Message-ID: <YH8K0gkYoZVfq0FV@lore-desk> (raw)
In-Reply-To: <20210420185440.1dfcf71c@carbon>
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
[...]
> > + TP_ARGS(map_id, processed, sched, xdp_stats),
> >
> > TP_STRUCT__entry(
> > __field(int, map_id)
> > __field(u32, act)
> > __field(int, cpu)
> > - __field(unsigned int, drops)
> > __field(unsigned int, processed)
>
> So, struct member @processed will takeover the room for @drops.
>
> Can you please test how an old xdp_monitor program will react to this?
> Will it fail, or extract and show wrong values?
Ack, right. I think we should keep the struct layout in order to maintain
back-compatibility. I will fix it in v4.
>
> The xdp_mointor tool is in several external git repos:
>
> https://github.com/netoptimizer/prototype-kernel/blob/master/kernel/samples/bpf/xdp_monitor_kern.c
> https://github.com/xdp-project/xdp-tutorial/tree/master/tracing02-xdp-monitor
>
> Do you have any plans for fixing those tools?
I update xdp_monitor_{kern,user}.c and xdp_redirect_cpu_{kern,user}.c in the
patch. Do you mean to post a dedicated patch for xdp-project tutorial?
Regards,
Lorenzo
>
>
>
>
> --
> Best regards,
> Jesper Dangaard Brouer
> MSc.CS, Principal Kernel Engineer at Red Hat
> LinkedIn: http://www.linkedin.com/in/brouer
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-04-20 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 14:05 [PATCH v3 bpf-next] cpumap: bulk skb using netif_receive_skb_list Lorenzo Bianconi
2021-04-20 16:54 ` Jesper Dangaard Brouer
2021-04-20 17:09 ` Lorenzo Bianconi [this message]
2021-04-22 10:59 ` Lorenzo Bianconi
2021-04-22 12:30 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YH8K0gkYoZVfq0FV@lore-desk \
--to=lorenzo.bianconi@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=song@kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox