From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C310FC43460 for ; Fri, 9 Apr 2021 13:52:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5BF961184 for ; Fri, 9 Apr 2021 13:52:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233619AbhDINwV (ORCPT ); Fri, 9 Apr 2021 09:52:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:45172 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232642AbhDINwV (ORCPT ); Fri, 9 Apr 2021 09:52:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 4F59561108; Fri, 9 Apr 2021 13:52:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617976328; bh=NFIRdHtpQ7HiIC9Gv8NFS7wN7NNJeQnF2jjJGj2F7aE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Om3IGO+XAfxPIpaJe+PncrqeBnM0qYlogQBI2pL1uWo1ua/3C4xXlkaLFJNIPK+1b 0LYO8932ZkYJpRE8P79fo+3XgehjxJnrokCg7tJxaZHM51BwXI6mIhG9nhJbpu1btt feybS2I4CnoPOLsXPYKLTI7t6SvNGe1lnxCW3dbQ35FnVMhkXi4cvh4yPaIj2gTIhj X177xCFW6LLHPhUC0USkG55z+UucN9xpQmHPZaixH1+0qFNDzi7W0jdOROzfMcTYHK X3HBFo2v7PM3yUR4Oh+rFZo+zK4INf7bhuBU4yCA8hk1sHgXZGToAhWOaQeVCYJVO/ zqC769Be0P9cA== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id BF3D540647; Fri, 9 Apr 2021 10:52:05 -0300 (-03) Date: Fri, 9 Apr 2021 10:52:05 -0300 From: Arnaldo Carvalho de Melo To: Yonghong Song Cc: Arnaldo , David Blaikie , dwarves@vger.kernel.org, Alexei Starovoitov , Bill Wendling , bpf , kernel-team@fb.com, Nick Desaulniers , Jiri Olsa Subject: Re: [RFT] prepping up pahole 1.21, wanna test it? was Re: [PATCH dwarves] dwarf_loader: handle subprogram ret type with abstract_origin properly Message-ID: References: <2d55d22b-d136-82b9-6a0f-8b09eeef7047@fb.com> <82dfd420-96f9-aedc-6cdc-bf20042455db@fb.com> <7cdd9179-df5e-bdb5-ab36-983acddcbc1c@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7cdd9179-df5e-bdb5-ab36-983acddcbc1c@fb.com> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Em Wed, Apr 07, 2021 at 03:53:32PM -0700, Yonghong Song escreveu: > > > On 4/7/21 8:40 AM, Arnaldo Carvalho de Melo wrote: > > Em Wed, Apr 07, 2021 at 12:37:09PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Wed, Apr 07, 2021 at 07:54:26AM -0700, Yonghong Song escreveu: > > > > Arnaldo, just in case that you missed it, please remember > > > > to fold the above changes to the patch: > > > > [PATCH dwarves] dwarf_loader: handle subprogram ret type with > > > > abstract_origin properly > > > > Thanks! > > > > > > Its there, I did it Sunday, IIRC: > > > > > > https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?h=tmp.master&id=9adb014930f31c66608fa39a35ccea2daa5586ad > > > > So I pushed it all to the master branch, hopefully some more people may > > feel encouraged to give it a try for the various things it fixes since > > 1.20: > > > > [acme@quaco pahole]$ git log --oneline v1.20.. > > ae0b7dde1fd50b12 (HEAD -> master, origin/tmp.master, origin/master, origin/HEAD, github/master, five/master, acme.korg/tmp.master, acme.korg/master) dwarf_loader: Handle DWARF5 DW_OP_addrx properly > > 9adb014930f31c66 dwarf_loader: Handle subprogram ret type with abstract_origin properly > > 5752d1951d081a80 dwarf_loader: Check .notes section for LTO build info > > 209e45424ff4a22d dwarf_loader: Check .debug_abbrev for cross-CU references > > 39227909db3cc2c2 dwarf_loader: Permit merging all DWARF CU's for clang LTO built binary > > 763475ca1101ccfe dwarf_loader: Factor out common code to initialize a cu > > d0d3fbd4744953e8 dwarf_loader: Permit a flexible HASHTAGS__BITS > > ffe0ef4d73906c18 btf: Add --btf_gen_all flag > > de708b33114d42c2 btf: Add support for the floating-point types > > 4b7f8c04d009942b fprintf: Honour conf_fprintf.hex when printing enumerations > > f2889ff163726336 Avoid warning when building with NDEBUG > > 8e1f8c904e303d5d btf_encoder: Match ftrace addresses within ELF functions > > 9fecc77ed82d429f dwarf_loader: Use a better hashing function, from libbpf > > 0125de3a4c055cdf btf_encoder: Funnel ELF error reporting through a macro > > 7d8e829f636f47ab btf_encoder: Sanitize non-regular int base type > > [acme@quaco pahole]$ > > I tested with llvm-project "main" branch and latest bpf-next. > clang non-lto, dwarf4/5: okay > clang thin-lto, dwarf4/5: okay > gcc (8.4.1, non-lto, default dwarf4): okay > > So pahole looks good. Thanks! Thanks a lot, in time for a friday release! :-) - Arnaldo