From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 717E8C07E9E for ; Sun, 11 Jul 2021 14:48:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59C5161159 for ; Sun, 11 Jul 2021 14:48:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233452AbhGKOv1 (ORCPT ); Sun, 11 Jul 2021 10:51:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22913 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233448AbhGKOv1 (ORCPT ); Sun, 11 Jul 2021 10:51:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626014920; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1hrLNyDSPTRLrzMIFQFpw//UU589xbINtFOVY47zgPk=; b=epbziitUOCxy8fOQe/O2HIxY2nSklQ6KelHAJxD3Ia7uajWZPIfdk8xpv3nl2t8SdHDtG7 B35trPR+2aOLtRaCUUCLG7VN3X78C3Dpo6JRqiqnN8lQjySTfzBcRujf5BnTtjHw17YW+N b0bgduImT3BtO6K8kWkBSAOvU3zqPW8= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-227-T6ZarkX2MD6TGBjV_UM18w-1; Sun, 11 Jul 2021 10:48:38 -0400 X-MC-Unique: T6ZarkX2MD6TGBjV_UM18w-1 Received: by mail-ed1-f70.google.com with SMTP id e3-20020a0564020883b029039ef9536577so6850398edy.5 for ; Sun, 11 Jul 2021 07:48:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1hrLNyDSPTRLrzMIFQFpw//UU589xbINtFOVY47zgPk=; b=ti5YjHbCz//3BfjeD3sTzZq3r4vmmHB0yxrJwdC+aB+Rukm4uzyiOaOCeQrUYDWT4v zfoVPlgZLap1A0MU/bZNyKKkCDPxUFagJEOm7XErjE9ASMr83OfkRREOJIxBPkPaeh1c YVGFTekDP0u47nZuodW9WdWVaWS4LduaqcJrO+w9KWBZXI1JALBwcpVmbmwQSy+RKi2e rurl/ckd7Y/k53eBpOTmsJYHS3odpVRgqYvv4khyMFKKt+w4R4C3HJwp4FxBKjPnKuFK dX1WpF6z7/U6SSmOdj0Hz3A9va3PNf+0eAEPartaQsz+b5P2Pi/s7qnpjOPsa5Ym8Jqe LEUQ== X-Gm-Message-State: AOAM532f6fSWQW2BTmp/P2P3DRsKRbM88JDBf1/AicQqP/1jQbk6Uf47 uHrQjUF8j8SNiz6niIt3lZflyqyrdhPlPBUV6B9Sdt4hpfgTLLiZOUKy2xJZZHR8m3YVfQ/eOJ7 WXI3YtKSkBpvD X-Received: by 2002:a17:907:3d8a:: with SMTP id he10mr26892249ejc.16.1626014917638; Sun, 11 Jul 2021 07:48:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSmSpVq+gJnx+4SgyvUwJb25PC5Dc0kFgIcBKxU+iX+/E1oF1AdihZiObMH0CjfWi3wBmhGA== X-Received: by 2002:a17:907:3d8a:: with SMTP id he10mr26892230ejc.16.1626014917466; Sun, 11 Jul 2021 07:48:37 -0700 (PDT) Received: from krava ([5.171.250.127]) by smtp.gmail.com with ESMTPSA id n18sm4019892ejl.74.2021.07.11.07.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Jul 2021 07:48:37 -0700 (PDT) Date: Sun, 11 Jul 2021 16:48:33 +0200 From: Jiri Olsa To: Andrii Nakryiko Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Networking , bpf , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Masami Hiramatsu , Alan Maguire Subject: Re: [PATCHv3 bpf-next 5/7] selftests/bpf: Add test for bpf_get_func_ip helper Message-ID: References: <20210707214751.159713-1-jolsa@kernel.org> <20210707214751.159713-6-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Jul 07, 2021 at 05:12:07PM -0700, Andrii Nakryiko wrote: > On Wed, Jul 7, 2021 at 2:54 PM Jiri Olsa wrote: > > > > Adding test for bpf_get_func_ip helper for fentry, fexit, > > kprobe, kretprobe and fmod_ret programs. > > > > Signed-off-by: Jiri Olsa > > --- > > .../bpf/prog_tests/get_func_ip_test.c | 42 +++++++++++++ > > .../selftests/bpf/progs/get_func_ip_test.c | 62 +++++++++++++++++++ > > 2 files changed, 104 insertions(+) > > create mode 100644 tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c > > create mode 100644 tools/testing/selftests/bpf/progs/get_func_ip_test.c > > > > [...] > > > + ASSERT_OK(err, "test_run"); > > + > > + result = (__u64 *)skel->bss; > > + for (i = 0; i < sizeof(*skel->bss) / sizeof(__u64); i++) { > > + if (!ASSERT_EQ(result[i], 1, "fentry_result")) > > + break; > > + } > > I dislike such generic loop over results. It's super error prone and > takes the same 5 lines of code that you'd write for explicit > > ASSERT_EQ(testX_result, 1, "testX_result"); /* 5 times */ ok > > > + > > + get_func_ip_test__detach(skel); > > no need to explicitly detach, __destroy does that automatically I see, will remove that thanks, jirka > > > + > > +cleanup: > > + get_func_ip_test__destroy(skel); > > +} > > [...] >