From: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
To: Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org, brouer@redhat.com,
davem@davemloft.net, kuba@kernel.org, ast@kernel.org,
daniel@iogearbox.net, shayagr@amazon.com,
john.fastabend@gmail.com, dsahern@kernel.org,
echaudro@redhat.com, jasowang@redhat.com,
alexander.duyck@gmail.com, saeed@kernel.org,
maciej.fijalkowski@intel.com, magnus.karlsson@intel.com,
tirthendu.sarkar@intel.com, toke@redhat.com
Subject: Re: [PATCH v13 bpf-next 05/18] net: xdp: add xdp_update_skb_shared_info utility routine
Date: Tue, 7 Sep 2021 15:44:44 +0200 [thread overview]
Message-ID: <YTdszJFfSUVCacJq@lore-desk> (raw)
In-Reply-To: <29fc47da-f9b3-9698-d58d-a06010945a21@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 2062 bytes --]
[...]
>
> Do we need to clear gso_type here as it is shared/union with xdp_frags_size
> ?
> (see below ... it is already cleared before call)
>
>
> > +}
> > +
> > /* Avoids inlining WARN macro in fast-path */
> > void xdp_warn(const char *msg, const char *func, const int line);
> > #define XDP_WARN(msg) xdp_warn(msg, __func__, __LINE__)
> > diff --git a/net/core/xdp.c b/net/core/xdp.c
> > index cc92ccb38432..504be3ce3ca9 100644
> > --- a/net/core/xdp.c
> > +++ b/net/core/xdp.c
> > @@ -531,8 +531,20 @@ struct sk_buff *__xdp_build_skb_from_frame(struct xdp_frame *xdpf,
> > struct sk_buff *skb,
> > struct net_device *dev)
> > {
> > + unsigned int frag_size, frag_tsize;
> > unsigned int headroom, frame_size;
> > void *hard_start;
> > + u8 nr_frags;
> > +
> > + /* xdp multi-buff frame */
> > + if (unlikely(xdp_frame_is_mb(xdpf))) {
> > + struct skb_shared_info *sinfo;
> > +
> > + sinfo = xdp_get_shared_info_from_frame(xdpf);
> > + frag_tsize = sinfo->xdp_frags_tsize;
> > + frag_size = sinfo->xdp_frags_size;
> > + nr_frags = sinfo->nr_frags;
> > + }
> > /* Part of headroom was reserved to xdpf */
> > headroom = sizeof(*xdpf) + xdpf->headroom;
> > @@ -552,6 +564,11 @@ struct sk_buff *__xdp_build_skb_from_frame(struct xdp_frame *xdpf,
> > if (xdpf->metasize)
> > skb_metadata_set(skb, xdpf->metasize);
> > + if (unlikely(xdp_frame_is_mb(xdpf)))
> > + xdp_update_skb_shared_info(skb, nr_frags,
> > + frag_size, frag_tsize,
> > + xdp_frame_is_frag_pfmemalloc(xdpf));
> > +
>
> There is a build_skb_around() call before this call, which via
> __build_skb_around() will clear top part of skb_shared_info.
> (Thus, clearing gso_type not needed ... see above)
yes, this is why I need save sinfo->nr_frags, sinfo->xdp_frags_size, ...
Regards,
Lorenzo
>
> > /* Essential SKB info: protocol and skb->dev */
> > skb->protocol = eth_type_trans(skb, dev);
>
>
> Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-09-07 13:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 12:35 [PATCH v13 bpf-next 00/18] mvneta: introduce XDP multi-buffer support Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 01/18] net: skbuff: add size metadata to skb_shared_info for xdp Lorenzo Bianconi
2021-09-07 14:39 ` Jesper Dangaard Brouer
2021-09-07 14:45 ` Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 02/18] xdp: introduce flags field in xdp_buff/xdp_frame Lorenzo Bianconi
2021-09-07 14:31 ` Jesper Dangaard Brouer
2021-09-07 14:46 ` Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 03/18] net: mvneta: update mb bit before passing the xdp buffer to eBPF layer Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 04/18] net: mvneta: simplify mvneta_swbm_add_rx_fragment management Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 05/18] net: xdp: add xdp_update_skb_shared_info utility routine Lorenzo Bianconi
2021-09-07 13:40 ` Jesper Dangaard Brouer
2021-09-07 13:44 ` Lorenzo Bianconi [this message]
2021-09-07 12:35 ` [PATCH v13 bpf-next 06/18] net: marvell: rely on " Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 07/18] xdp: add multi-buff support to xdp_return_{buff/frame} Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 08/18] net: mvneta: add multi buffer support to XDP_TX Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 09/18] net: mvneta: enable jumbo frames for XDP Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 10/18] bpf: add multi-buff support to the bpf_xdp_adjust_tail() API Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 11/18] bpf: introduce bpf_xdp_get_buff_len helper Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 12/18] bpf: add multi-buffer support to xdp copy helpers Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 13/18] bpf: move user_size out of bpf_test_init Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 14/18] bpf: introduce multibuff support to bpf_prog_test_run_xdp() Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 15/18] bpf: test_run: add xdp_shared_info pointer in bpf_test_finish signature Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 16/18] bpf: update xdp_adjust_tail selftest to include multi-buffer Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 17/18] net: xdp: introduce bpf_xdp_adjust_data helper Lorenzo Bianconi
2021-09-07 12:35 ` [PATCH v13 bpf-next 18/18] bpf: add bpf_xdp_adjust_data selftest Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTdszJFfSUVCacJq@lore-desk \
--to=lorenzo.bianconi@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=echaudro@redhat.com \
--cc=jasowang@redhat.com \
--cc=jbrouer@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=lorenzo@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@kernel.org \
--cc=shayagr@amazon.com \
--cc=tirthendu.sarkar@intel.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).