From: Shung-Hsi Yu <shung-hsi.yu@suse.com>
To: Connor O'Brien <connoro@google.com>
Cc: "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Michal Suchánek" <msuchanek@suse.de>
Subject: Re: [PATCH bpf-next] bpf: add config to allow loading modules with BTF mismatches
Date: Wed, 23 Feb 2022 12:34:24 +0800 [thread overview]
Message-ID: <YhW5UIQ5kf8Fr3kI@syu-laptop.lan> (raw)
In-Reply-To: <20220223012814.1898677-1-connoro@google.com>
On Wed, Feb 23, 2022 at 01:28:14AM +0000, Connor O'Brien wrote:
> BTF mismatch can occur for a separately-built module even when the ABI
> is otherwise compatible and nothing else would prevent successfully
> loading. Add a new config to control how mismatches are handled. By
> default, preserve the current behavior of refusing to load the
> module. If MODULE_ALLOW_BTF_MISMATCH is enabled, load the module but
> ignore its BTF information.
>
> Suggested-by: Yonghong Song <yhs@fb.com>
> Suggested-by: Michal Suchánek <msuchanek@suse.de>
> Signed-off-by: Connor O'Brien <connoro@google.com>
Maybe reference the discussion thread as well?
Link: https://lore.kernel.org/bpf/CAADnVQJ+OVPnBz8z3vNu8gKXX42jCUqfuvhWAyCQDu8N_yqqwQ@mail.gmail.com/
Otherwise
Acked-by: Shung-Hsi Yu <shung-hsi.yu@suse.com>
> ---
> Hello,
>
> In the discussion regarding BTF compatibility & modules, there seemed
> to be broad agreement that an option to ignore mismatches would be
> reasonable. Currently the only option for handling this problem seems
> to be to disable BTF entirely, so this would at least be an
> incremental improvement.
>
> Thanks,
> Connor
next prev parent reply other threads:[~2022-02-23 4:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 1:28 [PATCH bpf-next] bpf: add config to allow loading modules with BTF mismatches Connor O'Brien
2022-02-23 4:34 ` Shung-Hsi Yu [this message]
2022-02-23 5:08 ` Song Liu
2022-02-28 13:25 ` Daniel Borkmann
2022-02-28 13:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhW5UIQ5kf8Fr3kI@syu-laptop.lan \
--to=shung-hsi.yu@suse.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=connoro@google.com \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msuchanek@suse.de \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox