From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B046C433F5 for ; Thu, 3 Mar 2022 18:14:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233175AbiCCSPC (ORCPT ); Thu, 3 Mar 2022 13:15:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232699AbiCCSO6 (ORCPT ); Thu, 3 Mar 2022 13:14:58 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6B2C154D1F for ; Thu, 3 Mar 2022 10:14:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8151361917 for ; Thu, 3 Mar 2022 18:14:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72267C004E1; Thu, 3 Mar 2022 18:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646331251; bh=LVSPewNmGhXRyzLyEm10SYfCvlpreycNSgNgIJS1/7Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RbS2Kbu1DpPOkrxl9uxTq8uJZ4POT6c3roRLNtoB7aJYNAaudVX1w84/Epu/fQBkb cvTKzG72mN/5LUWhMTaw3VYuTFIeZVJxdT1blsse0UZwGu9A1Qu6Q+OvleUULCrFP6 sBqRLubxMSyQMeHjCZvMJHumKOK7s1lz/xQQZ6+M9/HZcAdDW/kF3rjy02WubZHArN SaL+efNtKATeAweYzaYHgiHuETkeqgB8919eV36nTpaVZ9aqZ8FrQNZOx5fvcCRoET J0aISwHFM+gXktb4IoUBb4aTjWxAL6LdASpHl/YQKLOdLCUi3+JNnO1jtuhbFUhiUM +mpxHGm5zUPBw== Date: Thu, 3 Mar 2022 11:14:04 -0700 From: Nathan Chancellor To: Kumar Kartikeya Dwivedi Cc: bpf@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Nick Desaulniers , llvm@lists.linux.dev Subject: Re: [PATCH bpf-next v2 5/8] compiler-clang.h: Add __diag infrastructure for clang Message-ID: References: <20220303045029.2645297-1-memxor@gmail.com> <20220303045029.2645297-6-memxor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220303045029.2645297-6-memxor@gmail.com> Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hi Kumar, Thanks for sending this along! On Thu, Mar 03, 2022 at 10:20:26AM +0530, Kumar Kartikeya Dwivedi wrote: > From: Nathan Chancellor > > Add __diag macros similar to those in compiler-gcc.h, so that warnings > that need to be adjusted for specific cases but not globally can be > ignored for LLVM compilation mode as well. I would word this last sentence as: "ignored when building with clang." Technically speaking, LLVM is not the one emitting the warnings, clang is :) this is useful with LLVM=1 or CC=clang. > Cc: Nathan Chancellor > Cc: Nick Desaulniers > Cc: llvm@lists.linux.dev > Signed-off-by: Nathan Chancellor You should add your signed-off-by here to notate that you have touched the patch per Documentation/process/submitting-patches.rst. It is also courteous to note that you wrote the commit message, something along the lines of: "[Kumar: Wrote commit message] Signed-off-by: Kumar Kartikeya Dwivedi " Regardless, this looks good to me with the context of the other two patches: https://lore.kernel.org/r/20220303045029.2645297-7-memxor@gmail.com/ https://lore.kernel.org/r/20220303045029.2645297-8-memxor@gmail.com/ Cheers, Nathan > --- > include/linux/compiler-clang.h | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > index 3c4de9b6c6e3..f1aa41d520bd 100644 > --- a/include/linux/compiler-clang.h > +++ b/include/linux/compiler-clang.h > @@ -68,3 +68,25 @@ > > #define __nocfi __attribute__((__no_sanitize__("cfi"))) > #define __cficanonical __attribute__((__cfi_canonical_jump_table__)) > + > +/* > + * Turn individual warnings and errors on and off locally, depending > + * on version. > + */ > +#define __diag_clang(version, severity, s) \ > + __diag_clang_ ## version(__diag_clang_ ## severity s) > + > +/* Severity used in pragma directives */ > +#define __diag_clang_ignore ignored > +#define __diag_clang_warn warning > +#define __diag_clang_error error > + > +#define __diag_str1(s) #s > +#define __diag_str(s) __diag_str1(s) > +#define __diag(s) _Pragma(__diag_str(clang diagnostic s)) > + > +#if CONFIG_CLANG_VERSION >= 110000 > +#define __diag_clang_11(s) __diag(s) > +#else > +#define __diag_clang_11(s) > +#endif > -- > 2.35.1 >