BPF List
 help / color / mirror / Atom feed
From: Jiri Olsa <olsajiri@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
	kernel-team@fb.com
Subject: Re: [PATCH bpf-next] bpftool: add BPF_TRACE_KPROBE_MULTI to attach type names table
Date: Fri, 18 Mar 2022 21:28:31 +0100	[thread overview]
Message-ID: <YjTrb3xpkpmLaM8V@krava> (raw)
In-Reply-To: <20220318150106.2933343-1-andrii@kernel.org>

On Fri, Mar 18, 2022 at 08:01:06AM -0700, Andrii Nakryiko wrote:
> BPF_TRACE_KPROBE_MULTI is a new attach type name, add it to bpftool's
> table. This fixes a currently failing CI bpftool check.

right, I forgot about this

> 
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> ---
>  tools/bpf/bpftool/common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c
> index 606743c6db41..b091923c71cb 100644
> --- a/tools/bpf/bpftool/common.c
> +++ b/tools/bpf/bpftool/common.c
> @@ -56,7 +56,6 @@ const char * const attach_type_name[__MAX_BPF_ATTACH_TYPE] = {
>  	[BPF_CGROUP_UDP6_RECVMSG]	= "recvmsg6",
>  	[BPF_CGROUP_GETSOCKOPT]		= "getsockopt",
>  	[BPF_CGROUP_SETSOCKOPT]		= "setsockopt",
> -
>  	[BPF_SK_SKB_STREAM_PARSER]	= "sk_skb_stream_parser",
>  	[BPF_SK_SKB_STREAM_VERDICT]	= "sk_skb_stream_verdict",
>  	[BPF_SK_SKB_VERDICT]		= "sk_skb_verdict",
> @@ -76,6 +75,7 @@ const char * const attach_type_name[__MAX_BPF_ATTACH_TYPE] = {
>  	[BPF_SK_REUSEPORT_SELECT]	= "sk_skb_reuseport_select",
>  	[BPF_SK_REUSEPORT_SELECT_OR_MIGRATE]	= "sk_skb_reuseport_select_or_migrate",
>  	[BPF_PERF_EVENT]		= "perf_event",
> +	[BPF_TRACE_KPROBE_MULTI]	= "trace_kprobe_bulti",

typo ;-)                                                ^

jirka

>  };
>  
>  void p_err(const char *fmt, ...)
> -- 
> 2.30.2
> 

      parent reply	other threads:[~2022-03-18 20:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18 15:01 [PATCH bpf-next] bpftool: add BPF_TRACE_KPROBE_MULTI to attach type names table Andrii Nakryiko
2022-03-18 15:44 ` Yonghong Song
2022-03-18 20:28 ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjTrb3xpkpmLaM8V@krava \
    --to=olsajiri@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox