From: Borislav Petkov <bp@alien8.de>
To: Josh Poimboeuf <jpoimboe@redhat.com>, bpf@vger.kernel.org
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] x86/speculation: Add missing prototype for unpriv_ebpf_notify()
Date: Tue, 26 Apr 2022 10:46:00 +0200 [thread overview]
Message-ID: <YmexSIL5pqNK63iH@zn.tnic> (raw)
In-Reply-To: <5689d065f739602ececaee1e05e68b8644009608.1650930000.git.jpoimboe@redhat.com>
+ bpf@vger.kernel.org
Let's sync with bpf folks on who takes this. I could route it through tip ...
On Mon, Apr 25, 2022 at 04:40:02PM -0700, Josh Poimboeuf wrote:
> Fix the following warnings seen with "make W=1":
>
> kernel/sysctl.c:183:13: warning: no previous prototype for ‘unpriv_ebpf_notify’ [-Wmissing-prototypes]
> 183 | void __weak unpriv_ebpf_notify(int new_state)
> | ^~~~~~~~~~~~~~~~~~
>
> arch/x86/kernel/cpu/bugs.c:659:6: warning: no previous prototype for ‘unpriv_ebpf_notify’ [-Wmissing-prototypes]
> 659 | void unpriv_ebpf_notify(int new_state)
> | ^~~~~~~~~~~~~~~~~~
>
> Fixes: 44a3918c8245 ("x86/speculation: Include unprivileged eBPF status in Spectre v2 mitigation reporting")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
> include/linux/bpf.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> index bdb5298735ce..ecc3d3ec41cf 100644
> --- a/include/linux/bpf.h
> +++ b/include/linux/bpf.h
> @@ -2085,6 +2085,8 @@ void bpf_offload_dev_netdev_unregister(struct bpf_offload_dev *offdev,
> struct net_device *netdev);
> bool bpf_offload_dev_match(struct bpf_prog *prog, struct net_device *netdev);
>
> +void unpriv_ebpf_notify(int new_state);
> +
> #if defined(CONFIG_NET) && defined(CONFIG_BPF_SYSCALL)
> int bpf_prog_offload_init(struct bpf_prog *prog, union bpf_attr *attr);
>
> --
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next parent reply other threads:[~2022-04-26 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5689d065f739602ececaee1e05e68b8644009608.1650930000.git.jpoimboe@redhat.com>
2022-04-26 8:46 ` Borislav Petkov [this message]
2022-04-26 23:36 ` [PATCH] x86/speculation: Add missing prototype for unpriv_ebpf_notify() Alexei Starovoitov
2022-04-28 9:12 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmexSIL5pqNK63iH@zn.tnic \
--to=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox