Re: [PATCH bpf-next 4/4] bpftool: Show also the name of type BPF_OBJ_LINK

Quentin Monnet
2022-06-29T16:22:12Z

On 29/06/2022 16:48, Yafang Shao wrote:
> For example,
> /sys/fs/bpf/maps.debug is a bpf link, when you run `bpftool map show` to
> show it,
> - before
> $ bpftool map show pinned /sys/fs/bpf/maps.debug
> Error: incorrect object type: unknown
> - after
> $ bpftool map show pinned /sys/fs/bpf/maps.debug
> Error: incorrect object type: link
>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> ---
> tools/bpf/bpftool/common.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/bpf/bpftool/common.c b/tools/bpf/bpftool/common.c
> index a0d4acd7c54a..5e979269c89a 100644
> --- a/tools/bpf/bpftool/common.c
> +++ b/tools/bpf/bpftool/common.c
> @@ -251,6 +251,7 @@ const char *get_fd_type_name(enum bpf_obj_type type)
> [BPF_OBJ_UNKNOWN] = "unknown",
> [BPF_OBJ_PROG] = "prog",
> [BPF_OBJ_MAP] = "map",
> + [BPF_OBJ_LINK] = "link",
> };
>
> if (type < 0 || type >= ARRAY_SIZE(names) || !names[type])

Reviewed-by: Quentin Monnet <quentin@isovalent.com>

Thanks!