Re: [PATCH bpf] xsk: mark napi_id on sendmsg()

Jakub Kicinski
2022-06-29T16:16:36Z

On Wed, 29 Jun 2022 14:53:34 +0200 Maciej Fijalkowski wrote:
> > > + __sk_mark_napi_id_once(sk, xs->pool->heads[0].xdp.rxq->napi_id);
> >
> > Please hide this hideous pointer chasing in something neater:
> > xsk_pool_get_napi_id() or something.
>
> Would it make sense to introduce napi_id to xsk_buff_pool then?
> xp_set_rxq_info() could be setting it. We are sure that napi_id is the
> same for whole pool (each xdp_buff_xsk's rxq info).

Would it be possible to move the marking to when the queue is getting
bound instead of the recv/send paths?