From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AE06C43334 for ; Thu, 14 Jul 2022 04:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234224AbiGNE1j (ORCPT ); Thu, 14 Jul 2022 00:27:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233878AbiGNE06 (ORCPT ); Thu, 14 Jul 2022 00:26:58 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF74B2B1AF; Wed, 13 Jul 2022 21:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wvxNVC7v6IRfhPDvi+vlda/Ydr6xcl7uzGy3JRiwJsk=; b=h6zx/qtQBkYoU+/liavyngGoGQ qsOPbojToSP07GYfoD4L1Rj/BdqAn48dD0TbbkCv6s0frYjwB2NxyHfS8sg/zexGgCpRPzE/TYQFN Li5G/evrqQyw+eHnbHDEYkA4UPfWAFvroO4nVkNVpo0j73IBWKbiJAUxbwqIo60Snl76iyVaNU4i/ PwqGuaMEcrYNxkwnJJxhEXZau/ZDirtLGlKAl9iQ27dKm5Nb57sDSzijqu4zBp3yAGRrB/+7UcQNB Eqroje4xhcnqhz99amuRSNTyDZf+KIL39W8xd/Abw/myVnEL3l8woK+0k4FNHzi/b7nJee72rFeH8 mFG3QhHQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBqOC-00AasH-TU; Thu, 14 Jul 2022 04:23:48 +0000 Date: Wed, 13 Jul 2022 21:23:48 -0700 From: Christoph Hellwig To: Song Liu Cc: Christoph Hellwig , Song Liu , bpf , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "linux-modules@vger.kernel.org" , "mcgrof@kernel.org" , "peterz@infradead.org" , "rostedt@goodmis.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "mhiramat@kernel.org" , "naveen.n.rao@linux.ibm.com" , "davem@davemloft.net" , "anil.s.keshavamurthy@intel.com" , "keescook@chromium.org" , "dave@stgolabs.net" , "daniel@iogearbox.net" , Kernel Team , "x86@kernel.org" , "dave.hansen@linux.intel.com" , "rick.p.edgecombe@intel.com" , "akpm@linux-foundation.org" Subject: Re: [PATCH bpf-next 1/3] mm/vmalloc: introduce vmalloc_exec which allocates RO+X memory Message-ID: References: <20220713071846.3286727-1-song@kernel.org> <20220713071846.3286727-2-song@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Jul 13, 2022 at 03:49:45PM +0000, Song Liu wrote: > > > > On Jul 13, 2022, at 3:08 AM, Christoph Hellwig wrote: > > > > NAK. This is not something that should be an exported public API > > ever. > > Hmm.. I will remove EXPORT_SYMBOL_GPL (if we ever do a v2 of this..) Even without that it really is not a vmalloc API anyway. Executable memory needs to be written first, so we should allocate it in that state and only mark it executable after that write has completed.