Re: [PATCH bpf-next v2 0/2] Fix test_probe_user on s390x

[Jiri Olsa <olsajiri@gmail.com>]

On Tue, Jul 26, 2022 at 03:40:06PM +0200, Ilya Leoshkevich wrote:
> Hi,
> 
> This is a fix for [1]: test_probe_user fails on s390x, because it hooks
> only connect(), but not socketcall(SYS_CONNECT).
> 
> Patch 1 adds this quirk to BPF_KSYSCALL documentation.
> Patch 2 fixes the test by attaching a prog to socketcall().
> 
> Best regards,
> Ilya
> 
> [1] https://lore.kernel.org/bpf/06631b122b9bd6258139a36b971bba3e79543503.camel@linux.ibm.com/
> 
> v1: https://lore.kernel.org/bpf/20220723020344.21699-1-iii@linux.ibm.com/
> v1 -> v2: Add CONFIG_ prefix to CLONE_BACKWARDS* symbols (Jiri).
>           Change the type of prog_names to make checkpatch happy.
>           Use prog_count everywhere (Jiri).
>           #ifdef out handle_sys_socketcall() on non-s390x (Jiri).

LGTM 

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> 
> Ilya Leoshkevich (2):
>   libbpf: Extend BPF_KSYSCALL documentation
>   selftests/bpf: Attach to socketcall() in test_probe_user
> 
>  tools/lib/bpf/bpf_tracing.h                   | 15 +++++---
>  .../selftests/bpf/prog_tests/probe_user.c     | 35 +++++++++++++------
>  .../selftests/bpf/progs/test_probe_user.c     | 32 +++++++++++++++--
>  3 files changed, 65 insertions(+), 17 deletions(-)
> 
> -- 
> 2.35.3
>