From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D4E9C43334 for ; Mon, 18 Jul 2022 21:08:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229886AbiGRVIw (ORCPT ); Mon, 18 Jul 2022 17:08:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231602AbiGRVIv (ORCPT ); Mon, 18 Jul 2022 17:08:51 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09922E2B; Mon, 18 Jul 2022 14:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658178531; x=1689714531; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KTQG4RmtxzPJAdkE4J2lkvPJbDNJSkkFFy8SjpeMAuI=; b=dGzy6WHDKy1HvTEQ8JCxDDeEQEmilUndMi0R1pu9UrBU2P83N7H5EnFY tCeYyMB2M5KcLFWovFbW699MDt01UoSbdVh+aYb2uyDBhcGQa0WDq9LzR md2sbe1ycr9GXDIkcnt5/0CWpCLnukROOXuxpKYtiXbwXvBRLzZb+5Umj ZsxwnDo7NPUUW/O2t/Umg+3U9UH6rgXvp7DeONmPpf2fnUzhQzeft49iv YSfRAbuQiV+++Hlk+TMoxf9vSjXCqZ6Wqyk+++xxXZrRgUsQu9kalVJrQ ggWa43OBO2/YTXWBeXAzlH86J41stoSKL5ruohAlMlaielG4mZil25A4x A==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="312007759" X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="312007759" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 14:08:50 -0700 X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="686874569" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 14:08:40 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oDXym-001OYZ-0w; Tue, 19 Jul 2022 00:08:36 +0300 Date: Tue, 19 Jul 2022 00:08:36 +0300 From: Andy Shevchenko To: Yury Norov Cc: linux-kernel@vger.kernel.org, Alexander Lobakin , Alexei Starovoitov , Alexey Klimov , Andrew Morton , Andrii Nakryiko , Ben Segall , Christoph Lameter , Dan Williams , Daniel Borkmann , Daniel Bristot de Oliveira , Dennis Zhou , Dietmar Eggemann , Eric Dumazet , Frederic Weisbecker , Guenter Roeck , Ingo Molnar , Isabella Basso , John Fastabend , Josh Poimboeuf , Juergen Gross , Juri Lelli , KP Singh , Kees Cook , Martin KaFai Lau , Mel Gorman , Miroslav Benes , Nathan Chancellor , "Paul E . McKenney" , Peter Zijlstra , Randy Dunlap , Rasmus Villemoes , Sebastian Andrzej Siewior , Song Liu , Steven Rostedt , Tejun Heo , Thomas Gleixner , Valentin Schneider , Vincent Guittot , Vlastimil Babka , Yonghong Song , linux-mm@kvack.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH 03/16] lib/test_bitmap: don't test bitmap_set if nbits == 0 Message-ID: References: <20220718192844.1805158-1-yury.norov@gmail.com> <20220718192844.1805158-4-yury.norov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220718192844.1805158-4-yury.norov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Jul 18, 2022 at 12:28:31PM -0700, Yury Norov wrote: > Don't test bitmap_set(bitmap, start, 0) as it's useless, most probably > a sign of error in real code, and makes CONFIG_DEBUG_BITMAP barking. No, the test of not useful and sign of an error is a good thing to test! Test cases may be positive, may be negative. Code shouldn't fail badly because of that. I tend to give a NAK here. -- With Best Regards, Andy Shevchenko